PHP kicks up an SQL syntax error

Question

I am new to PHP and SQL, but am creating a login system. The problem I have hit against is:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Surname typed in')' at line 5

So I look into the code, and I believe it refers to:

    mysql_query("INSERT INTO users (email, password, hash, forename, surname) VALUES(
        '". mysql_escape_string($email) ."',
        '". mysql_escape_string($password) ."',
        '". mysql_escape_string($hash) ."',
        '". mysql_escape_string($forename) .",
        '". mysql_escape_string($surname) ."') ") or die(mysql_error());

After looking over, I can't see a syntax error. Anyone spot it?

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. — John Conde
– John Conde, Commented Feb 23, 2013 at 23:43
If you print out the resulting SQL your error will be easy to spot — John Conde
– John Conde, Commented Feb 23, 2013 at 23:43
Thanks for the comments, but on reading the PDO info, I have no idea how to select a table. This would make it kind hard for me :) — Britmerican
– Britmerican, Commented Feb 24, 2013 at 0:07
@Splatter You select a table in PDO the same way you select it in mysql_*. — Daedalus
– Daedalus, Commented Feb 24, 2013 at 0:37
mysql_select_db("logintest") ? (sorry, I meant db, not table...2am!) — Britmerican
– Britmerican, Commented Feb 24, 2013 at 1:44

Daedalus · Accepted Answer · 2013-02-23 23:44:01Z

3

On this line:

'". mysql_escape_string($forename) .",
                                  // ^--- no closing single quote here.

You forgot the closing quote mark.

answered Feb 23, 2013 at 23:44

Daedalus

7,7125 gold badges40 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP kicks up an SQL syntax error

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related