ASP.NET MVC 3 Model null on submit

Question

View

@model Survey.Models.TakeSurveyViewModel
@{    
    Layout = "~/Views/Shared/_SiteLayout.cshtml";
}

<h2>SURVEY : @Model.Title</h2>
<h3>@Model.Description</h3>
<hr />

@using (Html.BeginForm("SubmitSurvey", "HomePage", FormMethod.Post, new { id = "surveyForm" }))
{
    for (int index = 0; index < Model.SurveyQuestions.Count; index++)
    {
        @* Editor Template - Null result *@ 
        @*SurveyQuestionModel item = Model.SurveyQuestions[index];
        @Html.EditorFor(x => item);*@

        <p>@Model.SurveyQuestions[index].QuestionText</p>
        @Html.DropDownListFor(item => Model.SurveyQuestions[index].OptionId, new SelectList(Model.SurveyQuestions[index].Options, "OptionId", "OptionText"), string.Empty)
    }
    <input type="submit" value="SubmitSurvey" />
}

ViewModel

public class TakeSurveyViewModel
    {
        public string Title { get; set; }
        public string Description { get; set; }
        public int SurveyId { get; set; }

        public List<SurveyQuestionModel> SurveyQuestions { get; set; } 

        public TakeSurveyViewModel() { }

        public TakeSurveyViewModel(int surveyId)
        {
            //Populate data - works ok.
        }
    }

DropDownList Model

public class SurveyQuestionModel
    {
        public int QuestionId { get; set; }
        public string QuestionText { get; set; }

        [Required(ErrorMessage = "Please select an option.")]        
        public int OptionId { get; set; }

        public IEnumerable<QuestionOption> Options { get; set; } 
    }

The page is rendering fine, with all the drop-downs with correct options. The id and name of each select is also unique -
id="SurveyQuestions_3__OptionId" name="SurveyQuestions[3].OptionId"

Controller Action

[HttpPost]
public ActionResult SubmitSurvey(TakeSurveyViewModel model)
{
     return !ModelState.IsValid ? TakeSurvey(model.SurveyId) : null;
}

But clicking on the submit button, controller action model is null.

Edit: Removed the 2x HTML.BeginForm

Edit 2: SurveyQuestions now has public setter. The issue seem to be still there. Please see this image:

enter image description here

You have 2 @Html.BeginForm? Was that intentional?

codingbiz
– codingbiz

2013-02-25 09:00:49 +00:00
Commented Feb 25, 2013 at 9:00 — codingbiz
– codingbiz, Commented Feb 25, 2013 at 9:00
Removed the extra, still null on submit.

A G
– A G

2013-02-25 09:06:00 +00:00
Commented Feb 25, 2013 at 9:06 — A G
– A G, Commented Feb 25, 2013 at 9:06

Valamas · Accepted Answer · 2013-02-25 09:17:13Z

3

Is the problem that you have SurveyQuestions being a private set?

-old answer-
You have 2 x (Html.BeginForm(Html.BeginForm I once forgot to have my form within a using statement which did the same sort of thing.

edited Feb 25, 2013 at 9:17

answered Feb 25, 2013 at 8:59

Valamas

24.8k25 gold badges111 silver badges182 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

A G Over a year ago

Just removed 1x BeginForm and its still null :(

A G Over a year ago

ok, on making it public the empty option elements are getting created but still everything is null. 2nd edit - screenshot of issue.

Valamas Over a year ago

When your form posts back, the only values that will be set for your Model will be the option list and the option id. Unless other items are present in your form, nothing else will be submitted back. Not even the option text.

Valamas Over a year ago

A way around the option text is to store the selected text in a hidden field next to the dropdown. javascript onchange code...

Valamas Over a year ago

Save it as a hidden field. Your model will only fill with what is posted from submitted form input elements.

|

Collectives™ on Stack Overflow

ASP.NET MVC 3 Model null on submit

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related