Converting text box input into an array

Question

fairly new C# developer here. I'm trying attempting to develop a mad lib generator. I have a button button_1 labeled "verb" that is supposed to generate a random verb. The verb comes from a string array, which is a list of verbs. I have another button button_5 labeled "add new verb" that is supposed to add the verb in the corresponding text box to the verb array. The problem I'm having is that it is only generating the last verb that I entered when I click button_1 which is labeled "verb".

Here is what the code looks like:

namespace WindowsFormsApplication1
{
    public class Arrays
    {
        public static string[] verbarray = new string[10];
    }
}

public void button5_Click(object sender, EventArgs e)
{
    for (int iverb = 0; iverb < Arrays.verbarray.Length; iverb++)
    {
        Arrays.verbarray[iverb] = Convert.ToString(this.txtaddverb.Text);
    }
}

public void button1_Click(object sender, EventArgs e)
{
    Random randomverb = new Random();
    verb.Text = Arrays.verbarray[randomverb.Next(0, Arrays.verbarray.Length)];
}

Your button5_Click() procedure is repopulating every element in your array with the current value of txtAddVerb.Text...so, when you click button1, you get a random selection from a list of identical array entries. I'll move this to an answer and add more detail. — David W
– David W, Commented Feb 27, 2013 at 16:50
I have edited your title. Please see, "Should questions include “tags” in their titles?", where the consensus is "no, they should not". — John Saunders
– John Saunders, Commented Feb 27, 2013 at 18:00

David W · Accepted Answer · 2013-02-27 17:03:55Z

2

Your verb-adding procedure is the problem.

You have set up a loop that iterates across all entries in your verb array, and replaces each one with the current value of your verb textbox. So, when you click the button to select a new verb, you're randomly selecting a verb from a list of entries that's always going to be identical once you've started adding verbs - and the verb chosen will always be the last one you added.

I'd suggest you take a look at a List, which can grow more readily and simplifies your Add problem. Might help!

// a little pseudocode to help with the notion..wire in your 
// event handlers accordingly
class VerbManager
{

 List<String> verbs= new List<String>();
 Random picker = new Random();

 public void addVerb(String newVerb)
 {
     verbs.Add(newVerb);
 }

 public string pickRandomVerb()
 {
     return verbs[picker.Next(0,verbs.Count)];
 }
}

edited Feb 27, 2013 at 17:03

answered Feb 27, 2013 at 16:57

David W

10.2k38 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

David W Over a year ago

Great! Glad it was helpful. Might consider picking it as the answer if you're so inclined. Have an awesome day!

Martin McGirk · Accepted Answer · 2013-02-27 17:00:19Z

1

In C# Arrays are of a fixed length, therefore, if your application is based around being able to add verbs to the common pool of verbs dynamically you should consider changing

public static string[] verbarray = new string[10];

to

public static List<string> verbList = new List<string>();

A List can grow in size, so if you already had 10 verbs and wanted to add another then that would be no problem. The code required in button5_Click would then simply read:

verbList.Add(txtaddverb.Text);

answered Feb 27, 2013 at 17:00

Martin McGirk

4114 silver badges13 bronze badges

Comments

Brian · Accepted Answer · 2013-02-27 16:55:11Z

0

Move:

Random randomverb = new Random();

to the class level.

edited Feb 27, 2013 at 16:55

Brian

5,1397 gold badges41 silver badges52 bronze badges

answered Feb 27, 2013 at 16:52

TalentTuner

17.6k6 gold badges40 silver badges65 bronze badges

Comments

Jared Price · Accepted Answer · 2013-02-27 17:53:44Z

0

Here is the code I ended up using after solving all bug problems:

namespace WindowsFormsApplication1

{

public class Lists

{
    public static List<string> verbList = new List<string>();

    public static Random randomverb = new Random();
}

}

public string pickRandomVerb()

    {
        return Lists.verbList[Lists.randomverb.Next(0, Lists.verbList.Count)];
    }
    public void button1_Click(object sender, EventArgs e)
    {
        if (Lists.verbList.Count > 0) verb.Text = pickRandomVerb();
    }

public void button5_Click(object sender, EventArgs e)

    {
        Lists.verbList.Add(txtaddverb.Text);
    }

answered Feb 27, 2013 at 17:53

Jared Price

5,4337 gold badges47 silver badges76 bronze badges

Comments

vikas · Accepted Answer · 2013-02-27 16:56:38Z

-2

You should correct your logic here:

   public void button5_Click(object sender7, EventArgs e)
    {
        for (int iverb = 0; iverb < Arrays.verbarray.Length; iverb++)
        {
            Arrays.verbarray[iverb] = Convert.ToString(this.txtaddverb.Text);
        }
    }

to what you want

public void button5_Click(object sender7, EventArgs e)
        {
            // suppose index 6
                Arrays.verbarray[6] = Convert.ToString(this.txtaddverb.Text);

        }

answered Feb 27, 2013 at 16:56

vikas

2,8224 gold badges29 silver badges37 bronze badges

3 Comments

David W Over a year ago

Why would you suggest he hardcode an array element value like that??

vikas Over a year ago

I just give him idea where he is wrong, he could take an integer in form and can do what he want in place of 6

Greg Over a year ago

To make your answer more viable you should show what you did where the fault is, then explain why it is wrong. Then provide a valid solution. It will make your answer more beneficial. Thank you for the contribution though.

Collectives™ on Stack Overflow

Converting text box input into an array

5 Answers 5

1 Comment

Comments

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related