PHP upload image -> Invalid file

Question

i'm on archlinux with lampp(last version) i learn php from w3c-school, i'm on page upload file and here my script can't upload nothing the only thing return me is Invalid File ever (.jpg .png ecc..) here is the code:

 <?php


include "config_db.php";

$name = "/upload/" . $_FILES['file']['name'];
$allowedExts = array("jpg", "jpeg", "gif", "png");
$extension = in_array(explode(".", $_FILES["file"]["name"]), $allowedExts);
if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/png")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 100000)
&& in_array($extension, $allowedExts))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br>";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br>";
    echo "Type: " . $_FILES["file"]["type"] . "<br>";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " kB<br>";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br>";

    if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
      echo '<img src="upload/' . $_FILES["file"]["name"] . '">';
      }
    }
  }
else
  {
  echo "Invalid file";
  }
?>

First things first DO NOT learn from W3Schools see why at w3fools.com — user1592648
– user1592648, Commented Feb 28, 2013 at 6:26

user521271 · Accepted Answer · 2013-02-28 04:24:39Z

1

If image name contains .(dot) then there is a problem. For example if the image name is like 12.212.jpg, when you explode the image name with .(dot) your extension will be .212. so in this case you need to use like below code.

$name = "/upload/" . $_FILES['file']['name'];
$allowedExts = array("jpg", "jpeg", "gif", "png");
$extension = explode(".", $_FILES["file"]["name"]);
$extension = end($extension);

It will give you the exact image format.

answered Feb 28, 2013 at 4:24

user521271

Sign up to request clarification or add additional context in comments.

Comments

Mikhail Vladimirov · Accepted Answer · 2013-02-28 05:05:27Z

0

Your are checking extension in incorrect way. Here is how it should be:

$allowedExts = array("jpg", "jpeg", "gif", "png");
$extension = pathinfo($_FILES['file']['name'], PATHINFO_EXTENSION);
header ("Content-Type: text/plain");
if ((($_FILES["file"]["type"] == "image/gif")
  || ($_FILES["file"]["type"] == "image/jpeg")
  || ($_FILES["file"]["type"] == "image/png")
  || ($_FILES["file"]["type"] == "image/pjpeg"))
  && ($_FILES["file"]["size"] < 100000)
  && in_array ($extension, $allowedExts)) echo "Success";
else echo "Error";

This code works fine for me together with the following form:

<form method="POST" enctype="multipart/form-data" action="upload.php">
  <input type="file" name="file" />
  <input type="submit" />
</form>

edited Feb 28, 2013 at 5:05

answered Feb 28, 2013 at 4:30

Mikhail Vladimirov

13.9k1 gold badge40 silver badges41 bronze badges

7 Comments

Mikhail Vladimirov Over a year ago

The code above works fine for me. Could you please show HTML code of your form?

starbuck Over a year ago

<html> <body> <form action="check_upload.php" method="post" enctype="multipart/form-data"> <label for="file">Filename:</label> <input type="file" name="file" id="file"><br> <input type="submit" name="submit" value="submit"> </form> </body> </html>

Mikhail Vladimirov Over a year ago

@user2041211 Could you insert print_r ($_FILES['file']) before if statement and show what will it print?

starbuck Over a year ago

Array ( [name] => bubble.jpg [type] => image/jpeg [tmp_name] => /tmp/phpNas8q1 [error] => 0 [size] => 758414 )

Mikhail Vladimirov Over a year ago

@user2041211 Your file is invalid because it obviously violates $_FILES["file"]["size"] < 100000 rule.

|

Dipesh Parmar · Accepted Answer · 2013-02-28 04:20:02Z

0

Your error is in below line.

$extension = in_array(explode(".", $_FILES["file"]["name"]), $allowedExts);

Must be as below.

$extension = pathinfo($_FILES['file']['name'], PATHINFO_EXTENSION);

And also change if condition as below.

if (in_array($extension, $allowedExts))

answered Feb 28, 2013 at 4:20

Dipesh Parmar

27.3k8 gold badges65 silver badges92 bronze badges

1 Comment

starbuck Over a year ago

i get invalid file changing the code.. maybe is a permission problem from linux?

Yogesh Suthar · Accepted Answer · 2013-02-28 04:20:46Z

0

change this condition

&& in_array($extension, $allowedExts))

to only this condition

&& $extension)

because you used in_array 2 times, 2nd one is unnecessary.

answered Feb 28, 2013 at 4:20

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

Comments

Edwin Alex · Accepted Answer · 2013-02-28 04:23:43Z

0

I think the problem is in in_array() function. You have already checked the extension in this line,

$extension = in_array(explode(".", $_FILES["file"]["name"]), $allowedExts);

Now $extension is value is TRUE.

So you cannot check this $extension in the if condition. Instead of that,

just check whether $extension is TRUE,

if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/png")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 100000)
&& $extension)

answered Feb 28, 2013 at 4:23

Edwin Alex

5,0944 gold badges31 silver badges51 bronze badges

2 Comments

starbuck Over a year ago

i have try to print $extension and is return me "filejpg"

Edwin Alex Over a year ago

@user2041211 The method you are using to get extension is wrong. First please change that. Then check

andyvn22 · Accepted Answer · 2014-01-12 21:09:34Z

0

I ran into the problem where if the extension was caps (i.e. image.JPG) it gave me invalid file. I used this code:

$t_image = strtolower($_FILES['file']['name']);

to solve the problem.

edited Jan 12, 2014 at 21:09

andyvn22

14.8k1 gold badge55 silver badges76 bronze badges

answered Jan 12, 2014 at 20:48

user3002720

133 bronze badges

Collectives™ on Stack Overflow

PHP upload image -> Invalid file

6 Answers 6

Comments

7 Comments

1 Comment

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

7 Comments

1 Comment

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related