jquery error with return bool value

Question

I am a newbie to javascript and i cant return the boolean value of the function.. i am validating the textboxes for null and return false if its empty help please?

validateForm : function() {
    $('.requiredField :input').each(function(){
        if ('input[type=text]'){
            if($(this).val().length === 0){
                    $(this).addClass('warning');
                    var  errorMsg = $('<br /><span>Please Fill in the TextBox</span>').addClass('warning');
                    errorMsg.insertAfter(this);
                    $(errorMsg).css('color','red');
                    $('.warning').css('border-color','red');
            //$(this).focus(function(){
                //$(this).removeClass('warning');   
                //$(this).parent().children('span').remove();
                //$(this).parent().children('br').remove();         
            //});
                    return false;
                }
            else 
                return true;
            }
        }); 

},
Form.validateForm(); // call to the function

Do you get an error message?

Indi
– Indi

2013-03-04 17:46:56 +00:00
Commented Mar 4, 2013 at 17:46 — Indi
– Indi, Commented Mar 4, 2013 at 17:46
@Kaf no messages or no error either

inputError
– inputError

2013-03-04 17:47:59 +00:00
Commented Mar 4, 2013 at 17:47 — inputError
– inputError, Commented Mar 4, 2013 at 17:47
return false to where? You're just executing the function.

Popnoodles
– Popnoodles

2013-03-04 17:48:20 +00:00
Commented Mar 4, 2013 at 17:48 — Popnoodles
– Popnoodles, Commented Mar 4, 2013 at 17:48
What is the question specifically?

Aaron Kurtzhals
– Aaron Kurtzhals

2013-03-04 17:49:36 +00:00
Commented Mar 4, 2013 at 17:49 — Aaron Kurtzhals
– Aaron Kurtzhals, Commented Mar 4, 2013 at 17:49

gen_Eric · Accepted Answer · 2013-03-05 17:21:13Z

2

You are returning from inside the .each(). That doesn't make your function return a value.

In an .each() loop, return false; is like using break;, and return true; is like using continue;.

You need to declare a variable outside of the .each(), set its value inside the loop, then return it after the loop.

edited Mar 5, 2013 at 17:21

answered Mar 4, 2013 at 17:48

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2063626 · Accepted Answer · 2013-03-04 17:51:58Z

0

check this line

if ('input[type=text]'){

it should be

 if($('input[type=text]')){

answered Mar 4, 2013 at 17:51

user2063626

Comments

Bryan · Accepted Answer · 2013-03-04 18:57:04Z

0

You can try this:

$('.requiredField :input').each(function(){
var i=$(this).val();

if(i == '' || i == null)
 {
 //execute your codes
 return false;
 }else{
 return true;
 }
});

edited Mar 4, 2013 at 18:57

answered Mar 4, 2013 at 17:59

Bryan

3582 silver badges12 bronze badges

Comments

user1738546 · Accepted Answer · 2013-03-04 19:00:26Z

It seems that you are trying to write a plugin? Try the following code:

(function($) {
    $.fn.validateForm = function()
    {
        var formID = $(this).attr('id');

        $('#'+ formID +' input[type=submit]').click(function(e)
        { 

            e.preventDefault();

            $('input[type=text]').each(function(){

                if($(this).val().length === 0){                 

                        $(this).addClass('warning');
                        var  errorMsg = $('<span>Please Fill in the TextBox</span>').addClass('warning');
                        errorMsg.insertAfter(this);
                        $(errorMsg).css('color','red');
                        $('.warning').css('border-color','red');          
                        return false;
                }else{
                    return true;
                }
            });
        });
    };
})(jQuery);

Matthew Perron · Accepted Answer · 2013-03-04 19:38:15Z

As mentionned by @RocketHazmat, your function needs to aggregate results from the inside loop and have a single exit point in order to validate (and add the css classes/html elements) every input.

You need to do something like this:

validateForm : function () {

        var invalidInputs = [];

        // only test the type='text' inputs
        $('.requiredField :input[type="text"]').each(function () {

            // if there is no value
            if ($(this).val() == undefined || $(this).val().length == 0) {

                $(this).addClass('warning');
                var errorMsg = $('<br /><span>Please Fill in the TextBox</span>').addClass('warning');
                errorMsg.insertAfter(this);
                $(errorMsg).css('color','red');
                $('.warning').css('border-color','red');

                // add the invalid input to an array
                invalidInputs.push($(this));
            }
        }); 

        // The form is only valid for no invalid inputs were found.
        return invalidInputs.length == 0;
    }

Collectives™ on Stack Overflow

jquery error with return bool value

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related