Simple Javascript HTML Replace

Question

I know I'm doing something silly. But I just can't figure it out. I want to replace some text inside an tag immediately when the document loads. I know the function is executing. But it konks out at the getElementById statement and I don't know why. The output should say "New Junk". But instead always says "Original Stuff".

<html>
<script>
window.onload = filltip();

  function filltip() {
   alert('xyz');
   var id = 'qourl';
   var txt = 'New Junk';
   //alert('current html=' + document.getElementById(id).innerHTML);
   document.getElementById(id).innerHTML = '?<span class="classic">' + txt +   
'</span>';
  }

</script>
<body>

<a href='#' id='qourl'>Original Stuff</a>

</body>
</html>

Niet the Dark Absol · Accepted Answer · 2013-03-05 17:04:42Z

7

Change your onload to this:

window.onload = filltip;

By writing window.onload = filltip(), you are actually calling filltip immediately, and using its return value as the onload function (in this case, undefined). In general, when you are assigning a function, you never want () on it unless the function very specifically returns another function.

answered Mar 5, 2013 at 17:04

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Thread7 Over a year ago

Thank you very much. It doesn't make a lot of sense to me but I tried it and it works.

Collectives™ on Stack Overflow

Simple Javascript HTML Replace

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related