Nested for loop not executing

Question

Could anyone tell me why the nested for loop in the code below doesn't execute? I.e. The "Hello World" is not printed. The first loop is being executed.

 for (int i = 0; i < data.Length; i++)
        {// Loop through array


            **for (int j = data.Length - 1; j < i; j--)**
            {
                // Loop backwards through array
                **Console.WriteLine("Hello World");**
                double subTotal = 0;   //Keeps track of current subsequence's value
                subTotal += data[j];
                if (bbestTotal < subTotal)
                {
                    bbestTotal = subTotal;
                }
            }

        }

You want for (int j = data.Length - 1; j > i; j--) Currently, j will always be bigger than or equal to i, so the terminating condition will fail immediately. — jonhopkins
– jonhopkins, Commented Mar 7, 2013 at 18:35
Cheers guys brain was fried lol. Answer below solved it. Cheers. — Lee Brindley
– Lee Brindley, Commented Mar 7, 2013 at 18:36

Sergey Kalinichenko · Accepted Answer · 2013-03-07 18:35:14Z

3

The loop is not executing because the loop condition

j < i

is false right at the beginning of the loop.

Since your loop advances j down, you should change the condition to

for (int j = data.Length - 1 ; j >= i ; j--)

answered Mar 7, 2013 at 18:35

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adil · Accepted Answer · 2013-03-07 18:34:40Z

2

The inner loop variable j is initialized with top value and it is greater then i so use j > i instead of j < i in loop condition part.

Change

for (int j = data.Length - 1; j < i; j--)

to

for (int j = data.Length - 1; j > i; j--)

answered Mar 7, 2013 at 18:34

Adil

148k25 gold badges217 silver badges207 bronze badges

Comments

nsconnector · Accepted Answer · 2013-03-07 18:42:34Z

0

The root cause of the problem is that the condition j < i for the 2nd for loop is always false for all values of i. So it never goes inside the body of the 2nd for loop. This should fix the problem:

for (int j = data.Length - 1; j > i; j--)

answered Mar 7, 2013 at 18:42

nsconnector

8366 silver badges12 bronze badges

Collectives™ on Stack Overflow

Nested for loop not executing

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related