Javascript URL Regex Issue in NodeJS

Question

So I need to grab all urls in a string and return them in an array.

Here is what I have so far:

        var comment = 'Check out www.google.com and http://bing.com';
        var regexp = new RegExp('((ftp|http|https):\/\/)?(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?', 'gi');
        var urls = comment.match(regexp);

Right now its not returning anything, whereas I need it to return both urls. I have searched google and stack and lots of examples, but none are working for my needs.

All help is greatly appreciated.

Thanks!

Jim

You can always use Regexper to create a graph reprenseting your Regexp allowed patterns. Not an answer to your question, but a nice tool to help debug Regexp issues. — Simon Boudrias
– Simon Boudrias, Commented Mar 8, 2013 at 22:01

SLaks · Accepted Answer · 2013-03-08 21:59:42Z

3

Your \ characters are being parsed as string escapes and aren't ending up in the regex.

Instead, you should use a regex literal:

/((ftp|http|https):\/\/)?(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?/gi

answered Mar 8, 2013 at 21:59

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

BigPoppa Over a year ago

thank you so much. One last issue I am having, is using the sentence "Check out www.google.com and bing.com" it is capturing all of the words whereas I just need it to capture the urls. Ideas?

Collectives™ on Stack Overflow

Javascript URL Regex Issue in NodeJS

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related