MySQL Query and display not working?

Question

My MySQL database is setup with the name "chatterr" with the table name, "maillist". I am currently using the php below:

<?php
mysql_connect("localhost","root","");

//query databae
$query = "SELECT * FROM maillist ORDER BY id DESC LIMIT 4";
$result=mysql_query($query) or die('Error, insert query failed');
$row=0;
$numrows=mysql_num_rows($result);

while($row<$numrows) {
    $id=mysql_result($result,$row,"id");
    $first_name=mysql_result($result, $row, "first_name");
    $last_name=mysql_result($result, $row, "last_name");
?>

<?php echo $id; ?>

<?php
$row++;
}
?>

It works on localhost but doesn't work in PHP. What's wrong with the code?

Why do you have several different <?php ... ?> tags? Wrap all of your php code in just one set of <?php ... ?> tags. You are splitting up your while loop. — Aiias
– Aiias, Commented Mar 10, 2013 at 6:05
@Aiias Thats irrelevant to the question, but I am doing that because there is html in between that i didn't upload, since its irrelevant. — Out
– Out, Commented Mar 10, 2013 at 6:07
Please, don't use mysql_* functions, they are officially deprecated. — A. Rodas
– A. Rodas, Commented Mar 10, 2013 at 6:08
@Harrison Howard - It's not irrelevant because you are splitting up your while loop and it will not work as you expect it to. Try using the alternate syntax for php while loops if you need to split up your code into several php code snippets. — Aiias
– Aiias, Commented Mar 10, 2013 at 6:09
What does "doesn't work" mean? "Doesn't work" is an inadequate description for us to understand the problem. What happened when you tried it? Did you get incorrect results? Did you get no results? If the results were incorrect, what made them incorrect? What were you expecting instead? Did you get any correct results? If so, what were they? Don't make us guess. — Andy Lester
– Andy Lester, Commented Mar 10, 2013 at 6:09

peterm · Accepted Answer · 2013-03-10 06:44:00Z

3

Select a database with mysql_select_db before querying it

mysql_connect("localhost","root","");
mysql_select_db("chatterr");

or specify the database name in the query

$query = "SELECT * FROM chatterr.students ORDER BY id DESC LIMIT 4";

UPDATE: Besides that your is connection probably failing. Change

mysql_connect("localhost","root","");

to

$db = mysql_connect("localhost","root","");
if (!$db) {
    die('Could not connect: ' . mysql_error());
}

to see if that's the case.

UPDATE3: Put it all together. Although that code has a LOT room for improvement it works perfectly fine on my machine.

<?php
$db = mysql_connect("localhost","root","");
if (!$db) {
    die('Could not connect: ' . mysql_error());
}
$db_selected = mysql_select_db("chatterr", $db);
if (!$db_selected) {
    die ('Could not select db: ' . mysql_error());
}

//query databae
$query = "SELECT * FROM test.students ORDER BY id DESC LIMIT 4";
$result=mysql_query($query) or die('Error, insert query failed');
$row=0;
$numrows=mysql_num_rows($result);

while($row<$numrows)
{
$id=mysql_result($result,$row,"id");
$first_name=mysql_result($result,$row,"first_name");
$last_name=mysql_result($result,$row,"last_name"); ?>

<?php echo $id; ?>

<?php

$row++;
}
?>

And please, don't use mysql_* functions for new code. They are deprecated. Use prepared statements with either PDO or MySQLi.

edited Mar 10, 2013 at 6:44

answered Mar 10, 2013 at 6:09

peterm

93k16 gold badges157 silver badges162 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Out Over a year ago

So would the dbname be "chatterr"?

peterm Over a year ago

If it is your database name then yes.

Out Over a year ago

Wait the database name or table name?

Out Over a year ago

Its not my connection, still getting: Parse error: syntax error, unexpected T_STRING in /Applications/XAMPP/xamppfiles/htdocs/chatterr/new/core/dbconnect.php on line 10. Line 10 is $result=mysql_query($query) or die mysql_error();

peterm Over a year ago

That's because you forgot parentheses in die(). It should be $result=mysql_query($query) or die(mysql_error());

|

Dead Man · Accepted Answer · 2013-03-10 06:38:48Z

0

Just do it this way :

<?php
$con = mysql_connect("localhost","root","") or die(mysql_error());
mysql_select_db("chatterr",$con) or die(mysql_error());

//query database
$query = "SELECT * FROM maillist ORDER BY id DESC LIMIT 4";
$result=mysql_query($query) or die(mysql_error());

while($row = mysql_fetch_array($result))
{
    $id = $row["id"];
    $first_name = $row["first_name"];
    $last_name = $row["last_name"];
}
?>

edited Mar 10, 2013 at 6:38

answered Mar 10, 2013 at 6:07

Dead Man

2,95125 silver badges37 bronze badges

6 Comments

Out Over a year ago

I am still getting "Error, insert query failed".

Dead Man Over a year ago

I just updated my code, you are having error in mysql query. Instead of printing Error Message, it's better to print mysql query error. Try that

Out Over a year ago

all it says is "No database selected".

Dead Man Over a year ago

I just updated my code, Now try it, it will 100% work. You didn't select the database in connectivity.

Out Over a year ago

Still staying no database. WHY? Idk why. I have code to select it.

|

Collectives™ on Stack Overflow

MySQL Query and display not working?

2 Answers 2

9 Comments

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related