Mysql Insert Into Error

Question

I've created a registration form and I'm adding the data with php but for some reason it will not let me add the data into the database. Can you see anything wrong with this code?

<?php
mysql_connect("localhost", "root", "password") or die("No Connection");;
mysql_select_db("music") or die("No Database");;

$username= mysql_real_escape_string($_REQUEST["username"]);
$password= mysql_real_escape_string($_REQUEST["password"]);
$email= mysql_real_escape_string($_REQUEST["email"]);
$hash = md5( rand(0,1000) );

mysql_query("INSERT INTO members (id, username, password, email, hash, active) VALUES('', '$username', '$password', '$email', '$hash', '')") or die("Can't Add");
if(mysql_affected_rows()>0){
echo "1";
}else{
echo "2";
}
?>

I Keep getting a Can't Add error indicating that there is a simple problem with the mysql_query row

Thank you

I think its in the id. insert query will not execute if primary keys are the same. — Snippet
– Snippet, Commented Mar 11, 2013 at 11:08

Rudi Visser · Accepted Answer · 2013-03-11 11:09:05Z

4

Can't add is not an error, just a catch all statement you added at the end.

To see your actual problem, change your code at the end of the mysql_query line to include the actual error retrieved from mysql_error().

mysql_query("INSERT INTO members (username, password, email, hash, active) VALUES('$username', '$password', '$email', '$hash', '')")
    or die("Can't Add - " . mysql_error());

That will give you more details regarding the error, if you post that, I can update my answer with the reason why.

Note that I've also removed the insertion of id, it's not needed if your column is AUTO_INCREMENT, which it should be.

answered Mar 11, 2013 at 11:09

Rudi Visser

22.1k6 gold badges74 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2152265 Over a year ago

Thank You - I ran the error code and found the problem - It was to do with the id column - It's not an auto_incriment but the id is made up of a unique code based on time + random numbers - Sorted now and the registration form works just fine - Thanks again

c.pramod · Accepted Answer · 2013-03-11 11:08:23Z

0

if id is your primary key then replane '' with null

answered Mar 11, 2013 at 11:08

c.pramod

6061 gold badge8 silver badges22 bronze badges

Comments

Sudip · Accepted Answer · 2013-03-11 11:10:49Z

0

Make id as auto-incremented primary key and remove it from insert query.

answered Mar 11, 2013 at 11:10

Sudip

2,0512 gold badges13 silver badges16 bronze badges

Comments

HYDER ALI · Accepted Answer · 2013-03-11 11:13:25Z

0

there may be unique constraints for any of the column

answered Mar 11, 2013 at 11:13

HYDER ALI

861 gold badge1 silver badge11 bronze badges

Comments

Fahim Parkar · Accepted Answer · 2013-03-11 11:20:35Z

0

Either have

mysql_query("INSERT INTO members (id, username, password, email, hash, active) 
             VALUES(null, '$username', '$password', '$email', '$hash', '')") or die("Can't Add");
                    ^^^^

OR

mysql_query("INSERT INTO members (username, password, email, hash, active) 
             VALUES( '$username', '$password', '$email', '$hash', '')") or die("Can't Add");

answered Mar 11, 2013 at 11:20

Fahim Parkar

31.8k46 gold badges168 silver badges285 bronze badges

Collectives™ on Stack Overflow

Mysql Insert Into Error

5 Answers 5

1 Comment

Comments

Comments

Comments

OR

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

OR

Comments

Your Answer

Sign up or log in

Post as a guest

Related