Issue with the If statement when executing an SQL Statement - c#

Question

i have made a form in c# to add data into my datatable, it works fine, all i want is to return a message when the data is inserted, and i am having an issue with that, the code is as follows:

conn.Open();
            SqlCommand cmd = conn.CreateCommand();
            cmd.CommandText = ("INSERT INTO datatable (Number_Plate,Registered_Keeper,Make,Model,Year_Of_Make,Colour,Engine_Size,Transmission,Fuel_Type) Values (@Number_Plate,@Registered_Keeper,@Make,@Model,@Year_Of_Make,@Colour,@Engine_Size,@Transmission,@Fuel_Type)");
            cmd.Parameters.AddWithValue("@Number_Plate", Plate.Text); 
            cmd.Parameters.AddWithValue("@Registered_Keeper", Keeper.Text);
            cmd.Parameters.AddWithValue("@Make", Make.Text);
            cmd.Parameters.AddWithValue("@Model", Model.Text);
            cmd.Parameters.AddWithValue("@Year_Of_Make", Year.Text);
            cmd.Parameters.AddWithValue("@Colour", Colour.Text);
            cmd.Parameters.AddWithValue("@Engine_Size", Engine.Text);
            cmd.Parameters.AddWithValue("@Transmission", Transmission.Text);
            cmd.Parameters.AddWithValue("@Fuel_Type", Fuel.Text);
            SqlDataReader reader = cmd.ExecuteReader();
            if (cmd.ExecuteNonQuery()==1)
            {
                button1.Visible = false;
                label10.Visible = true;
            }
            else
            {
                button1.Visible = false;
                label10.Text = "Data Not Added Please try Again!";
                label10.Visible = true;
            }
        }

when i run the code, i get an issue with the If statement ane the error is:

There is already an open DataReader associated with this Command which must be closed first.

any help appreciated.

Why do you have SqlDataReader reader = cmd.ExecuteReader(); in there? That doesn't make any sense... and the error is telling you exactly that. — Ilia G
– Ilia G, Commented Mar 12, 2013 at 17:41
Please read up on the using statement. SqlConnection, SqlCommand, and SqlDataReader (though you don't need it here) all implement IDisposable. — Austin Salonen
– Austin Salonen, Commented Mar 12, 2013 at 17:42

John Woo · Accepted Answer · 2013-03-12 17:39:48Z

3

just remove this line (you don't need it)

SqlDataReader reader = cmd.ExecuteReader();

makes no sense because you are inserting a record and not fetching on the database.

snippet,

        // other codes
        cmd.Parameters.AddWithValue("@Engine_Size", Engine.Text);
        cmd.Parameters.AddWithValue("@Transmission", Transmission.Text);
        cmd.Parameters.AddWithValue("@Fuel_Type", Fuel.Text);
        if (cmd.ExecuteNonQuery()==1)
        {
            button1.Visible = false;
        // other codes

answered Mar 12, 2013 at 17:39

John Woo

265k70 gold badges509 silver badges500 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2040978 Over a year ago

i have tried that code and it is displaying the label but not inserting the data into the data table

Matt Busche · Accepted Answer · 2013-03-12 17:41:03Z

0

You have open Connection to Database previously. So you need to close that first to execute.

conn.close()

edited Mar 12, 2013 at 17:41

Matt Busche

14.4k5 gold badges38 silver badges63 bronze badges

answered Mar 12, 2013 at 17:40

Fiham Zuher

332 silver badges13 bronze badges

Collectives™ on Stack Overflow

Issue with the If statement when executing an SQL Statement - c#

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related