Android SQLite update query showing error

Question

I have a following table:

sdb.execSQL("create table if not exists userprofile (id integer primary key, profilename text, user text);");

I want to update profilename field in Android SQLite.

So I used the following code:

ContentValues cv= new ContentValues();
cv.put("user",et4.getText().toString());
String admin="user1";
sdb.update("userprofile", cv, "profilename = " + admin, null);

The table have profilename value as user1. But when I execute this I am getting

03-14 09:12:55.851: E/SQLiteLog(26616): (1) no such column: user1

Please help me to resolve the problem.

Thanks in advance.

check values in content value...

Sumedh Tambat
– Sumedh Tambat

2013-03-14 09:24:37 +00:00
Commented Mar 14, 2013 at 9:24 — Sumedh Tambat
– Sumedh Tambat, Commented Mar 14, 2013 at 9:24

Simon Dorociak · Accepted Answer · 2013-03-14 09:19:59Z

1

Try to do it like this:

sdb.update("userprofile", cv, "profilename = ?", new String[] {"user1"});

I recommend this approach. Usage of placeholders solve problems like this. Your approach doesn't work because you are missing single quotes.

answered Mar 14, 2013 at 9:19

Simon Dorociak

33.5k10 gold badges70 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

deadfish Over a year ago

does it work like insert into or just update specific field?

Simon Dorociak Over a year ago

@100kg this will update userprofile with profileName = 'user1'

deadfish Over a year ago

can I somehow use ContentValues to insert into without writting insert into ?

Simon Dorociak Over a year ago

@100kg for sure you can as couple of values cv.put("column_name", "new value"); insert into clause is db.insert() method.

Simon Dorociak Over a year ago

@100kg of you want to write full query as "insert into Table values(?,?)" you need to use SQLiteStatement stmt = db.compileStatement(queryString); stmnt.bindString(1, "val1"); stmnt.bindString(2, "val2"); stmnt.executeInsert();

Piyas De · Accepted Answer · 2013-03-14 09:19:58Z

1

It should be -

ContentValues cv= new ContentValues();
cv.put("user",et4.getText().toString());
String admin="user1";
sdb.update("userprofile", cv, "profilename = '" + admin +"'", null);

Hope this help you.

answered Mar 14, 2013 at 9:19

Piyas De

1,76215 silver badges27 bronze badges

1 Comment

krishna kumar Over a year ago

your approach too is working fine.Thank you.So +1 to you also

Collectives™ on Stack Overflow

Android SQLite update query showing error

2 Answers 2

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related