Remove a string from string array

Question

I am very beginner in JavaScript.

I have an string array like this : 123,432,123,543,123,123

I want to remove the 3dr number from this string.

I have found following function to remove a text value from an string array, but it's not working for arrays with duplicated values in them.

Array.prototype.removeByValue = function (val) {

    for (var i = 0; i < this.length; i++) {
        if (this[i] == val) {
            this.splice(i, 1);
            break;
        }
    }
}

Any suggestions to solve this issue is appreciated.

Presumably you have an array like this: [123, 432, 123, 543, 123, 123]. You just want to remove the third element, no matter what it is? — lonesomeday
– lonesomeday, Commented Mar 14, 2013 at 13:26

silly · Accepted Answer · 2013-03-14 13:28:11Z

2

you can use filter:

var ary = ['three', 'seven', 'eleven'];

ary = ary.filter(function(v) {
    return v !== 'seven';
});

and extend your array

Array.prototype.remove = function(value) {
    return ary.filter(function(v) {
        return v != value;
    });

}

var ary = ['three', 'seven', 'eleven'];
ary = ary.remove('seven'),
console.log(ary)

answered Mar 14, 2013 at 13:28

silly

7,8972 gold badges26 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Esailija Over a year ago

But this is not in-place, any other references are still pointing to an array with "three seven eleven"

Esailija · Accepted Answer · 2013-03-14 13:41:22Z

0

Just keep going then:

Array.prototype.removeByValue = function (val) {

    for (var i = 0; i < this.length; i++) {
        if (this[i] == val) {
            this.splice(i, 1); 
            i--; //Decrement after removing
            //No break
        }
    }
}

The more idiomatic way is this.splice(i--, 1) but this should be clearer in what order they happen.

var a = [1,2,1,1,2,2];
a.removeByValue(1);
a; //[2, 2, 2]

answered Mar 14, 2013 at 13:41

Esailija

140k24 gold badges280 silver badges328 bronze badges

Comments

amir moradifard · Accepted Answer · 2013-03-16 11:19:17Z

-1

To resolve the issue, I added an unique ID to each element, like {A1;123,A2;432,A3;123,A4;543,A5;123,A6;123} and in this case finding a specific element is much easier with same function.

answered Mar 16, 2013 at 11:19

amir moradifard

3631 gold badge9 silver badges26 bronze badges

2 Comments

silly Over a year ago

if you do this, it is not a array, its a object!

amir moradifard Over a year ago

its array, @silly!!! Does it matter what characters you have in your elements? @silly

Collectives™ on Stack Overflow

Remove a string from string array

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related