writing List <string> elements to excel

Question

I'm just using a simple code to write a list of string to excel as following

        Excel.Application excelApp = new Excel.Application();
        string myPath = Environment.CurrentDirectory + path + "\\reselts.xlsx";
        excelApp.Workbooks.Open(myPath);

        List <string> allterms = new List<string>(alltext.Split(' '));

         allterms= allterms.Distinct().ToList();
        allterms.RemoveAll(String.IsNullOrEmpty);

        for (int i = 1; i < allterms.Count + 1; i++ )
        {

            excelApp.Cells[i, 1] = allterms[i];

        }
        excelApp.Visible = true;

But I got an error "index was out of range" ! what is wrong with my procedure ? can any help please ?

StoriKnow · Accepted Answer · 2013-03-16 18:47:41Z

1

allterms.Count is the total number of items in the List. Your loop is trying to access Count + 1, which doesn't exist.

For example, say there are 10 items in allterms. The total count is equal to 10 and the index ranges from 0 - 9, which is 10 items. What you're doing in your for loop is accessing items at the index range 1 - 10, which is skipping the item at index 0 and attempting to access the item at index 10, which doesn't exist.

Try this:

for (int i = 0; i < allterms.Count; i++ )
{
    excelApp.Cells[i + 1, 1] = allterms[i];
}

answered Mar 16, 2013 at 18:47

StoriKnow

5,8676 gold badges40 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

StoriKnow Over a year ago

Very welcome, glad to help. If this (or any other response) answered your question, don't forget to mark it as such so others can know.

outcoldman · Accepted Answer · 2013-03-16 18:50:06Z

1

In excel all indexes are 1-based. In C# all indexes are 0-based. In your code looks like you use 1-based access model for both: for excel and list.

Also, to increase the speed of inserting, it will be better to set values for range instead of for each cell. You can take a look on example I have here: http://outcoldman.com/en/blog/show/201

answered Mar 16, 2013 at 18:50

outcoldman

11.9k2 gold badges29 silver badges31 bronze badges

1 Comment

FSm Over a year ago

Could you post an example using my procedure here please !!

Collectives™ on Stack Overflow

writing List <string> elements to excel

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related