Counter not updating in javascript?

Question

I am writing a function that will take a variable then check to see if that variable is in localStorage, and if it's not, add it to localStorage. If it is in localStorage, it appends a number to the end, so that a new localStorage key gets added.

So far, I've gotten this far:

var title = "Test";
test(title);

function test(title) {
    counter = 0;
    console.log("counter = " + counter);
    if (localStorage.getItem(title)) {
        counter = counter + 1;
        title = title + " " + counter;
        console.log("found " + title);
        console.log("found " + counter);
        test(title);
    } else {
        console.log("not found " + title);
        console.log("not found " + counter);
        localStorage.setItem(title, " ");
        load();
    }
}

function load() {
    for (var key in localStorage) {
        $(".keys").append(key + "<br />");
    }
}

That way, when I run the function say 5 times, I should have localStorage keys for:

Test, Test 1, Test 2, Test 3, Test 4

Instead, I have localStorage keys for

Test, Test 1, Test 1 1, Test 1 1 1, Test 1 1 1 1

I'm not sure why the numbers aren't adding, but here's a jsFiddle to demonstrate: http://jsfiddle.net/charlescarver/x6ALG/5/

It's a string, so you are not adding but concatenating. Use parseInt before adding — Jacopofar
– Jacopofar, Commented Mar 18, 2013 at 18:45
counter is not a string. It should be a number object, since I'm only adding 1 to the previous number, which is a number object, 0. — Charlie
– Charlie, Commented Mar 18, 2013 at 18:47
You set counter to 0 at the beginning of the function, so it's reset every time you call test(). — JJJ
– JJJ, Commented Mar 18, 2013 at 18:48
I think it would work if you just moved var counter = 0 to the start of the script outside the function. Also, if title = title + " " + counter, you're appending a space and the counter number to the existing title, so if title is "Test 1" and counter is 2, you'll get "Test 1" + " " + 2 == "Test 1 2". — JJJ
– JJJ, Commented Mar 18, 2013 at 18:52
You probably didn't move it far enough (it has to be defined before you call the test() function). — JJJ
– JJJ, Commented Mar 18, 2013 at 19:01

JJJ · Accepted Answer · 2013-03-18 19:01:15Z

1

Move the counter to outside the function so that you don't reset it to zero each time you call the function, and keep the title parameter clean so that you can perform arithmetic with the counter.

var counter = 0;
var title = "Test";

test(title);

function test(title) {
    var newTitle = title + " " + counter;
    console.log("counter = " + counter);
    if (localStorage.getItem( newTitle )) {

        counter = counter + 1;

        console.log("found " + newTitle);
        console.log("found " + counter);

        test(title);
    } else {

        console.log("not found " + newTitle);
        console.log("not found " + counter);
        localStorage.setItem( newTitle, " " );
        load();
    }
}

function load() {
    for (var key in localStorage) {
        $(".keys").append(key + "<br />");
    }
}

Note the newTitle variable.

Demo: http://jsfiddle.net/x6ALG/7/

answered Mar 18, 2013 at 19:01

JJJ

33.2k20 gold badges95 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Charlie Over a year ago

Although, is there anyway for it to not add a number to the original? So that it goes Test, Test 1, Test 2... etc?

JJJ Over a year ago

var newTitle = title; if( counter > 0 ) newTitle += " " + counter;

Charlie Over a year ago

Perfect, here's a complete jsFiddle if anyone wants it: jsfiddle.net/charlescarver/x6ALG/10

ManSe · Accepted Answer · 2013-03-18 18:56:54Z

0

Dont initialize the counter to 0 inside your function test. Make it global and intialize it outside the function. Every time your function is called, it starts the count from 0.

answered Mar 18, 2013 at 18:56

ManSe

818 bronze badges

1 Comment

Charlie Over a year ago

Could you provide an example.

Collectives™ on Stack Overflow

Counter not updating in javascript?

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related