PHP MySQL query outputs only a two-element array

Question

I just made a quick little script with SQL query. Now when I go to phpmyadmin and execute

SELECT name FROM players WHERE online='1' ORDER BY name ASC

It outputs the desired players ( 0TheMonk, Player, Veeve )

But with PHP:

$query=mysql_query("SELECT name FROM players WHERE online='1' ORDER BY name ASC");
$query_array=mysql_fetch_array($query);
echo implode(',',$query_array);

It echoes: 0TheMonk,0TheMonk

Instead of: 0TheMonk,Player,Veeve

It always outputs the first player in the array, twice. What am I doing wrong? Thanks in advance.

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. — Kermit
– Kermit, Commented Mar 18, 2013 at 19:48
mysql_fetch_array only returns one row. See the docs: php.net/mysql_fetch_array — gen_Eric
– gen_Eric, Commented Mar 18, 2013 at 19:55

Sumit Bijvani · Accepted Answer · 2013-03-18 19:52:10Z

2

Use while loop

$query=mysql_query("SELECT name FROM players WHERE online='1' ORDER BY name ASC");
while($query_array=mysql_fetch_array($query))
{
    echo $query_array['name'].",";
}

edited Mar 18, 2013 at 19:52

answered Mar 18, 2013 at 19:46

Sumit Bijvani

8,17518 gold badges52 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user2183800 Over a year ago

Thank you, it actually helped, but now I have every player twice. 0TheMonk,0TheMonkPlayer,PlayerVeeve,Veeve That's even more weird O.o

user2183800 Over a year ago

Thank you so so so so much! <3

Prasanth Bendra · Accepted Answer · 2013-03-19 08:50:42Z

0

Try this : Almost same as Sumits answer.

$res    = array();
$query=mysql_query("SELECT name FROM players WHERE online='1' ORDER BY name ASC");
while($query_array=mysql_fetch_array($query))
{
    $res[]   = $query_array['name'];
}

echo implode(",",$res);

In this case there will not a extra , at the ens

answered Mar 19, 2013 at 8:50

Prasanth Bendra

33.1k9 gold badges56 silver badges74 bronze badges

Collectives™ on Stack Overflow

PHP MySQL query outputs only a two-element array

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related