Ruby function list file recursively

Question

i need a recursive function to list files in a folder:

def procdir(dirname)
  data = ''
  Dir.foreach(dirname) do |dir|
    dirpath = dirname + '/' + dir
    if File.directory?(dirpath) then
      if dir != '.' && dir != '..' then
        #puts "DIRECTORY: #{dirpath}" ; 
        procdir(dirpath)
      end
    else
      data += dirpath
    end
  end
  return data
end

but the result: is null

Could you tell me the filesystem? Does dirname contains multiple directories itself within it? — Arup Rakshit
– Arup Rakshit, Commented Mar 19, 2013 at 15:06
possible duplicate of One-liner to Recursively List Directories in Ruby? — dbenhur
– dbenhur, Commented Mar 19, 2013 at 15:14

dbenhur · Accepted Answer · 2013-03-19 15:04:42Z

21

Stdlib Dir#glob recurses when you give it the ** glob.

def procdir(dir)
  Dir[ File.join(dir, '**', '*') ].reject { |p| File.directory? p }
end

answered Mar 19, 2013 at 15:04

dbenhur

20.5k4 gold badges52 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

indi Over a year ago

Thank for your responses, i understand my problem. dbenhur, your code is great! here is my code if it can help someone def procdir(dir) Dir[ File.join(dir, '*', '') ].reject { |p| File.directory? p } end file = procdir('mypath') #puts file file.each do |filename| #puts filename test = filename.scan(/SomeRegex/).flatten puts test (..) end Thank you all

GoldenWest Over a year ago

Nice this is exactly what I was looking for

ckruse · Accepted Answer · 2013-03-19 14:56:54Z

8

Use the find module:

require 'find'

pathes = []
Find.find('.') do |path|
  pathes << path unless FileTest.directory?(path)
end

puts pathes.inspect

answered Mar 19, 2013 at 14:56

ckruse

9,7701 gold badge27 silver badges25 bronze badges

Comments

Jikku Jose · Accepted Answer · 2017-03-10 09:08:17Z

7

Old thread but perhaps someone might find it useful:

array_of_all_files = Dir .glob("**/*") .reject { |file_path| File.directory? file_path }

edited Mar 10, 2017 at 9:08

answered Nov 5, 2013 at 5:24

Jikku Jose

18.9k11 gold badges44 silver badges63 bronze badges

7 Comments

dbenhur Over a year ago

Why did you repeat an answer nearly identical to the one I posted eight months earlier? Dir::[] is the same as Dir.glob. File.join('**', '*') is a more portable way to say "**/*".

Jikku Jose Over a year ago

I am sorry, I didn't know they were identical. And I felt this was more readable (probably, since I used it a bunch of times and never knew another representation of it).

Eric Duminil Over a year ago

@dbenhur : Just curious, why would File.join('**', '*') be more portable than "**/*". It works on Linux/Windows/MacOs as far as I know.

dbenhur Over a year ago

@EricDuminil Because there are more operating systems than that. File::join will join on File::SEPARATOR and not assume the underlying OS understands /.

Eric Duminil Over a year ago

@dbenhur: I agree that it can be a problem when using those paths with other programs. But File.join doesn't change anything : File.join("a","b") is "a/b", even on Windows.

|

Mark Wilkins · Accepted Answer · 2013-03-19 15:05:43Z

1

It looks like there are a couple of problems with the recursion:

The else clause appears to associated with the wrong if. It needs to be associated with the first if.
The result of the recursive procdir call should be added to data.

If you indent the code a little more cleanly, it would probably be easier to spot problems like that. The following contains the two fixes:

def procdir(dirname)
  data = ''
  Dir.foreach(dirname) do |dir|
    dirpath = dirname + '/' + dir
    if File.directory?(dirpath) then
      if dir != '.' && dir != '..' then
        #puts "DIRECTORY: #{dirpath}" ; 
        data += procdir(dirpath)
      end
    else
      data += dirpath
    end
  end
  return data
end

answered Mar 19, 2013 at 15:05

Mark Wilkins

41.3k5 gold badges61 silver badges111 bronze badges

1 Comment

indi Over a year ago

Thank for your responses, i understand my problem.

Bruno Casali · Accepted Answer · 2017-03-09 13:19:39Z

0

If you know the file extensions you will have just use this:

Dir[Rails.root.join('config/locales/**/*.{rb,yml}')]

answered Mar 9, 2017 at 13:19

Bruno Casali

1,3902 gold badges17 silver badges32 bronze badges

Collectives™ on Stack Overflow

Ruby function list file recursively

5 Answers 5

2 Comments

Comments

7 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

7 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related