PHP insert into database query

Question

I am trying to insert values into a database table, a row is inserted but blank no values are inserted. Only the order_id which is the primary key with auto increment increase.

php code:

<?php
        $user_get = mysql_query("SELECT * FROM users"); 
        while($row_user = mysql_fetch_assoc($user_get)){
            if($row_user['username'] == $_SESSION['username']){
                $row_user['first_name'] = $res1;
                $row_user['last_name'] = $res2;

                $store_order ="INSERT INTO oko (user, product) VALUES ('$res1', '$res2')";
                mysql_query($store_order);
            }
        }
?>

Are you sure $res1 and $res2 have a value? Print $store_order before you execute the query; — Ares
– Ares, Commented Mar 19, 2013 at 21:51
LOL seems you'll be having a hard time to pick the right answer from the three answers provided :D — thaJeztah
– thaJeztah, Commented Mar 19, 2013 at 21:54

juco · Accepted Answer · 2013-03-19 21:52:19Z

5

Your assignments are backwards. I think you meant to:

$res1 = $row_user['first_name'];
$res2 = $row_user['last_name'];

answered Mar 19, 2013 at 21:52

juco

6,3423 gold badges27 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Explosion Pills · Accepted Answer · 2013-03-19 21:52:44Z

3

Don't you mean:

$res1 = $row_user['first_name'];
$res2 = $row_user['last_name'];

You could also update the SELECT to have a WHERE clause that checks $_SESSION['username'].

You could also just do an INSERT/SELECT:

INSERT INTO oko (user, product)
SELECT
    first_name, last_name
FROM
    users
WHERE
    username = '$_SESSION["username"]'

Your code is vulnerable to injection. You should use properly parameterized queries with PDO/mysqli

answered Mar 19, 2013 at 21:52

Explosion Pills

192k56 gold badges341 silver badges417 bronze badges

Collectives™ on Stack Overflow

PHP insert into database query

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related