cannot response.write on connection node.js

Question

I wrote this code in node.js :

var http = require('http');
http.createServer(function (req, res) {
  res.writeHead(200, {'Content-Type': 'text/plain'});
    res.write('start\n');
    var mysql      = require('mysql');
    var connection = mysql.createConnection({
      host     : 'hostname',
      user     : 'user',
      password : 'pass',
      database : 'dbname',
    });

    connection.connect();

    connection.query('SELECT code FROM user_type', function(err, rows, fields) {
      if (err) throw err;
            //This for is to run on all the results
            for(var i=0;i<2;i++){
            res.write('name:',rows[i].code);
        }
    });

    connection.end();

  res.end('End');
}).listen(8080);
console.log('Server running');

my questions are: 1. why did the res.write in the for loop print nothing in my html page? 2. what to write instead of 2 in the for?

Jonathan Lonowski · Accepted Answer · 2013-03-20 22:08:58Z

3

The issue is the timing of execution.

Since connection.query() is asynchronous, it delays the execution of the callback function to when the query finishes, but allows the surrounding block of code to continue in the meantime. This results in res.end('End') being executed before res.write('name:',rows[i].code).

To also delay res.end(), move it inside the callback:
```
connection.query(..., function(err, rows, fields) {
    if (err) throw err;

    for (...) {
        res.write('name:',rows[i].code);
    }
    res.end('End');
});
```
rows should be an Array when there isn't an err, so you can use its length property:
```
for (var i = 0; i < rows.length; i++) {
```
It's also a common practice to store the value of length in a local variable:
```
for (var i = 0, len = rows.length; i < len; i++) {
```

edited Mar 20, 2013 at 22:08

answered Mar 20, 2013 at 21:34

Jonathan Lonowski

124k35 gold badges203 silver badges202 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

cannot response.write on connection node.js

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related