Use variable in SQLite Query

Question

First of all I've looked up several topics on this but nothing specifically addressing this issue in Java.

I have the following method.

public String getCount() {
    SQLiteDatabase db = smokinDBOpenHelper.getWritableDatabase();
    String w = "Home";
    Cursor cursor = db.rawQuery("select * from " + smokinDBOpenHelper.INCIDENTS_TABLE + 
            " where " + KEY_LOCATION + " = 'Home'", null);

    int i = cursor.getCount();
    String s = ("You have " + i + " entries in this column");

    return s;
}

I would like this query to use the variable above it rather than a specific hard coded String "Home".

I've tried + {w} + {w%} + w and a few others, nothing seems to work

Hoan Nguyen · Accepted Answer · 2013-03-21 00:24:29Z

2

Try

Cursor cursor = db.rawQuery("select * from " + smokinDBOpenHelper.INCIDENTS_TABLE + 
        " where " + KEY_LOCATION + " = '" + w + "'", null);

answered Mar 21, 2013 at 0:24

Hoan Nguyen

18.2k3 gold badges52 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:02:46Z

2

It's better to user the selectionArgs parameters that you set to null in your rawQuery method.

An example can be founde here rawQuery(query, selectionArgs)

edited May 23, 2017 at 12:02

CommunityBot

11 silver badge

answered Mar 21, 2013 at 0:27

Ozzie

11.7k4 gold badges23 silver badges25 bronze badges

1 Comment

IrishWhiskey Over a year ago

For sure, otherwise its easy to attack my db. I just needed this part to work first. Now I'm on to that, thank you though

Collectives™ on Stack Overflow

Use variable in SQLite Query

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related