PHP Variable in Echoing JavaScript

Question

I have an php script that is echoing JavaScript, in the JavaScript there are PHP variables

echo '<script type="text/javascript"> 
     FB.init({
    appId: "myid",
    channelUrl: "//mysite/channel.html",
    status: true, // check login status
    cookie: true, // enable cookies to allow the server to access the session
    xfbml: true // parse XFBML
});
FB.getLoginStatus(function (response) {
    if (response.status === "connected") {
        FB.api("me/bookvote:download", "post", {
            book: "<?php echo "http://mysite/auction_details.php?name=$item_details["name"]&auction_id=$item_details["auction_id"]";?>",
            fb:explicitly_shared = "true" //? Is syntactically valid but creates a global
        }, //Missing a , here?

However, I am still getting:

Uncaught SyntaxError: Unexpected identifier for book: http://mysite.xom/auction_details.php?name=$item_details["name"]&auction_id=$item_details["auction_id"]";?>",

What should I do?

You are using a tag <?php inside php echo function. It should be like book: "http://......'.$item_details.'...." — Mikhail Chernykh
– Mikhail Chernykh, Commented Mar 21, 2013 at 23:01
possible duplicate of Passing PHP Variable into JavaScript Function — Rachel Gallen
– Rachel Gallen, Commented Mar 22, 2013 at 0:35

Madara's Ghost · Accepted Answer · 2013-03-21 23:04:09Z

3

I can spot multiple issues:

You try to print variables inside of single quotes. They won't be parsed, you need double quotes, or better yet, HEREDOC, or even better yet, don't use echo to print HTML/JavaScript.
You try to use additional <?php ?> tags inside of your echo. That would obviously not work.

Try this. I have removed the echo. Note that the larger PHP tag ends there.

?>
<script type="text/javascript"> 
     FB.init({
    appId: "myid",
    channelUrl: "//mysite/channel.html",
    status: true, // check login status
    cookie: true, // enable cookies to allow the server to access the session
    xfbml: true // parse XFBML
});
FB.getLoginStatus(function (response) {
    if (response.status === "connected") {
        FB.api("me/bookvote:download", "post", {
            book: "<?php echo "http://mysite/auction_details.php?name=$item_details["name"]&auction_id=$item_details["auction_id"]";?>",
            fb:explicitly_shared = "true" //? Is syntactically valid but creates a global
        }, //Missing a , here?

answered Mar 21, 2013 at 23:04

Madara's Ghost

176k52 gold badges274 silver badges314 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

adeneo Over a year ago

I have no idea if this works, but I'll upvote it just on the "don't use echo to print HTML/JavaScript" line. Seems like a great idea.

Steve Tauber · Accepted Answer · 2013-03-21 23:04:35Z

0

You'll want to end your echo quote so it's like this:

echo '<script type="text/javascript"> 
....
            book: "http://mysite/auction_details.php?name=' . $item_details["name"] . '&auction_id=' . $item_details["auction_id"] . '",
....

answered Mar 21, 2013 at 23:04

Steve Tauber

10.3k5 gold badges45 silver badges48 bronze badges

Comments

Carlos Castillo · Accepted Answer · 2013-03-21 23:03:56Z

0

Change this line:

book: "http://mysite/auction_details.php?name=' . $item_details["name"] . '&auction_id=' . $item_details["auction_id"] . '",

answered Mar 21, 2013 at 23:03

Carlos Castillo

9076 silver badges7 bronze badges

Comments

Paul Calabro · Accepted Answer · 2013-03-21 23:04:10Z

0

Those variables never got converted to their actual values that are supposed to be used. Try breaking that string into multiple parts via concatenation.

answered Mar 21, 2013 at 23:04

Paul Calabro

1,9161 gold badge17 silver badges34 bronze badges

Collectives™ on Stack Overflow

PHP Variable in Echoing JavaScript

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related