Undefined variable in foreach loop

Question

When I do a foreach() loop, the current array element's value $recipient is not defined on the line ->to($recipient). Why is this?

PHP Code (throws error)

foreach($recipients as $recipient) {
    Mail::send('emails.invite', $data, function($m){
        $m
            ->from('[email protected]', Auth::user()->name)
            ->to($recipient)
            ->subject('Auth::user()->name has invited you!');
    });
}

Error

Notice: Undefined variable: recipient

PHP Code (NO error)

foreach($recipients as $recipient) {
    echo $recipient;
}

hek2mgl · Accepted Answer · 2013-03-25 00:39:53Z

3

You missed the use keyword. Change the code to :

foreach($recipients as $recipient) {
    Mail::send('emails.shareListing', $data, function($m) use($recipient) {
        $m
            ->from('[email protected]', Auth::user()->name)
            ->to($recipient)
            ->subject('Auth::user()->name has shared a listing with you!');
    });
}

See this documentation - especially the third example. Quote:

Closures may also inherit variables from the parent scope. Any such variables must be declared in the function header.

answered Mar 25, 2013 at 0:39

hek2mgl

159k31 gold badges263 silver badges279 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

hek2mgl Over a year ago

You are welcome! Had the problem once to. The PHP documentation is saying not much about this.

Cal · Accepted Answer · 2013-03-25 00:41:01Z

1

It's because you're inside the scope of the function.

Assuming you're using the PEAR package here, I don't understand why you're passing a function at all: http://pear.php.net/manual/en/package.mail.mail.send.php

If you meant to be doing this, you can use the use keyword to pass the variable into the function scope:

function($m) use($recipient) {

answered Mar 25, 2013 at 0:41

Cal

7,13227 silver badges28 bronze badges

Collectives™ on Stack Overflow

Undefined variable in foreach loop

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related