MySQL won't update with URL variable

Question

I'm having troubles getting my code to work properly. If I type it into phpMyAdmin it works, but when I try it in the code, it doesn't update the database.

<?php
$con = mysql_connect("SERVER","USER","PASSWORD");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("DATABASE", $con);

$sp=mysql_real_escape_string($_GET['file']);

$query = "UPDATE TDB SET WEIGHT=100000 WHERE PATH='$sp'"; 

mysql_close($con);

?>

You have your quesry in a string, but you never execute it. See php.net/manual/en/function.mysql-query.php — j08691
– j08691, Commented Mar 25, 2013 at 16:08
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. — Kermit
– Kermit, Commented Mar 25, 2013 at 16:08
If you want to learn PHP PDO (newer "way" of connecting to databases) go to phpro.org/tutorials/Introduction-to-PHP-PDO.html, its a great resource. I learned allot from using it. — StenW
– StenW, Commented Mar 25, 2013 at 16:15

llanato · Accepted Answer · 2013-03-25 16:35:17Z

1

Try out this code snippet and see how you get on.

<?php
$con = mysql_connect("SERVER","USER","PASSWORD");
if (!$con) {
  die('Could not connect: ' . mysql_error());
} else {
    mysql_select_db("DATABASE", $con);
    $sp=mysql_real_escape_string($_GET['file']);
    $query = "UPDATE TDB SET WEIGHT=100000 WHERE PATH='$sp'"; 
    $result = mysql_query($query);
    mysql_close($con);
}
?>

I would recommend doing it this way as mysql is no longer supported by PHP.

<?php
$mysqli = new mysqli("localhost", "user", "password", "database");

if (!$mysqli) {
  die('Could not connect: ' . $mysqli->connect_error);
} else {
    $sp = $mysqli->real_escape_string($_GET['file']);
    $query = "UPDATE TDB SET WEIGHT=100000 WHERE PATH='$sp'"; 
    $mysqli->query(query);
    $mysqli->close();
}
?>

edited Mar 25, 2013 at 16:35

answered Mar 25, 2013 at 16:22

llanato

2,5036 gold badges42 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc B · Accepted Answer · 2013-03-25 16:09:03Z

0

You're not EXECUTING your query. You're just defining a string that happens to contain some SQL, e.g.

$sql = "blah blah blah";
$result = mysql_query($sql) or die(mysql_error()); <--forgot this

answered Mar 25, 2013 at 16:09

Marc B

362k44 gold badges433 silver badges508 bronze badges

Comments

austinh · Accepted Answer · 2013-03-25 16:12:35Z

0

<?php
$con = mysql_connect("SERVER","USER","PASSWORD");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("DATABASE", $con);

$sp=mysql_real_escape_string($_GET['file']);

$sql = "UPDATE TRACKDB SET WEIGHT=100000 WHERE PATH='$sp'"; 

$result = mysql_query($sql) or die(mysql_error());

mysql_close($con);

?>

answered Mar 25, 2013 at 16:12

austinh

1,0716 gold badges13 silver badges35 bronze badges

Collectives™ on Stack Overflow

MySQL won't update with URL variable

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related