Coding style: function and procedures coding standard

Question

Ch 7.6 of Code Complete 2 is confusing me, I've attached some sample code (in php) mind telling me which style is the best? or suggest something better? thanks

Style 1

public function register($user, $pass) {
 if($this->model->isRegistered($user)
 {
  return false;
 }
 else if($this->twitter->login($user, $pass))
 {
  return $this->model->addUser($user, $pass);
 }

 return false;
}

Style 2

public function register($user, $pass) {
 if($this->model->isRegistered($user)
 {
  return false;
 }

 $this->twitter->login($user, $pass);
 if($this->twitter->isLoggedIn())
 {
  return $this-model->addUser($user, $pass);
 }

 return false;
}

Style 3

public function register($user, $pass) {
 if($this->model->isRegistered($user)
 {
  return false;
 }

 $status = $this->twitter->login($user, $pass);
 if($status)
 {
  return $this->model->addUser($user, $pass);
 }

 return false;
}

I'm currently making use of Style 1. Though I'm not quite sure if its the right one.

Honestly, I wouldn't know which style to choose. I'd say it would not make much difference. — b.roth
– b.roth, Commented Oct 14, 2009 at 8:19
The different styles should show varying degrees of readability. Though the differences aren't really obvious to me since I'm the one coding 'em. That's why I'm asking this question. — lemon
– lemon, Commented Oct 14, 2009 at 9:55

ntd · Accepted Answer · 2009-10-14 16:45:51Z

3

I don't want to sound too rude but I like noone of the 3 proposed styles. If I'm checking for conditions preventing the execution of a function, I'll always stick with this style. In general:

function action()
{
    if ($guard_condition1)
        return $failure;

    if ($guard_condition2)
        return $failure;

    do_action();
    return $success;
}

So I'd rewrite your code as following:

public function register($user, $pass)
{
    if ($this->model->isRegistered($user))
        return false;

    if (!$this->twitter->login($user, $pass))
        return false;

    return $this->model->addUser($user, $pass);
}

Anyway, if you need an opinion on what you proposed, I'd vote for style 3.

answered Oct 14, 2009 at 16:45

ntd

7,4451 gold badge31 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kamilos · Accepted Answer · 2009-10-14 08:23:43Z

2

In Style 1 "if" and "else if" is used on different conditions, so it doesn't make sense.

In Style 2 lines:

 $this->twitter->login($user, $pass);
 if($this->twitter->isLoggedIn())

are too much hard to read in some situations but it's a proper.

For me the best one is Style 3.

answered Oct 14, 2009 at 8:23

Kamilos

8152 gold badges11 silver badges25 bronze badges

1 Comment

Zano Over a year ago

By definition else if always has a different condition than the preceding if, so your objection doesn't make sense :-)

Collectives™ on Stack Overflow

Coding style: function and procedures coding standard

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related