PHP - Returning result from database and passing the value to another function

Question

I have a class called TariffFareController, and I am getting the correct fare from the database as follows:-

class TariffFareController {

public static function getTourFare($fieldTour) {

       $pdo = new SQL();
       $dbh = $pdo->connect(Database::$serverIP, Database::$serverPort, Database::$dbName, Database::$user, Database::$pass);

       try {

           $query =   "SELECT Fare FROM tbltours
                       WHERE TourName = '$fieldTour'";

           $stmt = $dbh->prepare($query);

           $stmt->execute();

           $result = $stmt->fetchColumn();

           $stmt->closeCursor();

           return $result;

           $dbh = null;

       }

       catch (PDOException $pe) {
           die("Error: " .$pe->getMessage(). " Query: ".$stmt->queryString);
       }

}

}

I then want to be able to check the result in my private get fare function:-

private static function getFare($int_terminate) {

    // $tour_fare = (the result from getTourFare)

        if ($tour_fare != null) {

            // do something

        }

        else {

        // do something else

        }

    }

How would I go about getting the $result from getTourFare and using this in the private getFare function?

Any help would be much appreciated!

Statements after return $result; don't get executed. You need to move $dbh = null; up or it won't be done. — Barmar
– Barmar, Commented Mar 31, 2013 at 8:36

Matteo Tassinari · Accepted Answer · 2013-03-31 08:30:49Z

3

If both functions are in the same class, simply do

$tour_fare = self::getTourFare();

else you can call it from outside the class using

$tour_fare = TariffFareController::getTourFare();

Please notice that in the getTourFare() function the line $dbh = null; will never get executed 'cause you're returning from the function before executing it. I have also to say that I think that that line is quite useless cause the $dbh variable will go out of scope anyway.

answered Mar 31, 2013 at 8:30

Matteo Tassinari

18.6k8 gold badges65 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

nsilva Over a year ago

self::getTourFare(); comes up with errors as $fieldTour is a required parameter. I've changed this to self::getTourFare($fieldTour); then it shows an error as $fieldTour is undefined, any suggestions?

Matteo Tassinari Over a year ago

Well, I did not place parameters 'cause I supposed you knew how to handle them... If you have to call getTourFare from getFare, and getTourFare required a parameter $fieldTour then also getFare will need that parameter so to be able to pass it to the other function.

SoldierCorp · Accepted Answer · 2013-03-31 08:51:48Z

0

You can do some like this.

Call to getTourFare through getFare and if return data, do can process data instead return false you do any thing.

class TariffFareController {


private static function getFare() {
    if (self::getTourFare("any_field")) {
        /* Data success */
    } else {
        /* No data */
    }
}
public static function getTourFare($fieldTour) {

   $pdo = new SQL();
   $dbh = $pdo->connect(Database::$serverIP, Database::$serverPort, Database::$dbName, Database::$user, Database::$pass);

   try {

       $query =   "SELECT Fare FROM tbltours
                   WHERE TourName = '$fieldTour'";

       $stmt = $dbh->prepare($query);

       if (!$stmt->execute()) return false;

       if ($stmt->rowCount() > 0) {
           $result = $stmt->fetchColumn();

           $stmt->closeCursor();

           return $result;
       } else {
           return false;
       }

       $dbh = null;

   }

   catch (PDOException $pe) {
       die("Error: " .$pe->getMessage(). " Query: ".$stmt->queryString);
   }

}

}

edited Mar 31, 2013 at 8:51

answered Mar 31, 2013 at 8:32

SoldierCorp

7,69016 gold badges64 silver badges103 bronze badges

2 Comments

nsilva Over a year ago

I didn't think you could use $this-> within static content

SoldierCorp Over a year ago

Sure, I'm sorry.. don't see the static.

Collectives™ on Stack Overflow

PHP - Returning result from database and passing the value to another function

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related