jquery how to write proper json object in c#

Question

what is the best way to write json object in c#? I have a piece of code which is supposed to get data from DB and write json object but I haven't had my mind clear about this

[WebMethod]
public static string get_specialities(string ProfessionalID)
{
    Database db = DatabaseFactory.CreateDatabase("Connection String2");
    DbCommand dbCommand;
    dbCommand = db.GetStoredProcCommand("select_Professionals_Speciality");
    db.AddInParameter(dbCommand, "prof_id", DbType.Int16, Convert.ToInt16(ProfessionalID));
    IDataReader dr = db.ExecuteReader(dbCommand);
    //[{ id: 3, name: "test3" }]
    string return_str="[";
    int i = 0;
    while (dr.Read()) {
        if (i > 0)
            return_str += ",";
        return_str += "{id:" + dr["SpecialtyID"].ToString().Trim() + ",name:" + dr["SpecialtyName"].ToString().Trim() + "}";
        i++;
    }
    return_str += "]";
    return return_str;
}

this returns the object below, which is in wrong format

{"d":"[{id:67,name:Kardiyoloji}]"}

what am I doing wrong?

NewtonSoft.JSON is what you looking for. And little sugestion use StringBuilder when you creating string it's make a different in performance — Harry89pl
– Harry89pl, Commented Apr 4, 2013 at 12:56

palaѕн · Accepted Answer · 2013-04-04 13:08:17Z

2

Try this using JavaScriptSerializer class:

List<Person> people = new List<Person>();
Person p = new Person();

while (dr.Read()) {
    p = new Person();
    p.id = dr["SpecialtyID"].ToString().Trim();
    p.name = dr["SpecialtyName"].ToString().Trim();
    people.Add(p);
}

JavaScriptSerializer serializer = new JavaScriptSerializer();
string return_str = serializer.Serialize(people);

answered Apr 4, 2013 at 13:08

palaѕн

74.2k17 gold badges123 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Draykos · Accepted Answer · 2013-04-04 12:54:56Z

0

About the code you provided, the right json should be:

{"d":[{"id":67,"name":"Kardiyoloji"}]}

You can check with jsonlint: http://jsonlint.com/

Use a serializer. I suggest NewtonSoft. You can find a lot of samples around, otherwise ask for a snippet of code here

answered Apr 4, 2013 at 12:54

Draykos

8429 silver badges16 bronze badges

Comments

Soner Gönül · Accepted Answer · 2013-04-04 12:57:06Z

0

directly converting to string is not a good idea generally... you should use serialize such as jobs... but you can try like this

{"d":'[{"id":67,"name":"Kardiyoloji"}]'}

are you gonna deserialize value of d again ?

edited Apr 4, 2013 at 12:57

Soner Gönül

99.1k103 gold badges224 silver badges375 bronze badges

answered Apr 4, 2013 at 12:55

tanaydin

5,32632 silver badges50 bronze badges

1 Comment

Arif YILMAZ Over a year ago

how can I return it as json object rather than string

Harry89pl · Accepted Answer · 2013-04-04 13:00:24Z

0

I assumed that you don't know how to write special char in your string which is " double quota in your case?

replace: "{id:" + dr["SpecialtyID"].ToString().Trim() + ",name:" + dr["SpecialtyName"].ToString().Trim() + "}";

for

"{\"id\":" + dr["SpecialtyID"].ToString().Trim() + "\",\"name\":\"" + dr["SpecialtyName"].ToString().Trim() + "\"}";

will do what you need. But better way is using a NewtonSoft serializer for JSON handling.

Hope it help.

answered Apr 4, 2013 at 13:00

Harry89pl

2,43512 gold badges46 silver badges64 bronze badges

Comments

Alberto De Caro · Accepted Answer · 2013-04-04 13:00:59Z

0

I suggest you to avoid manually building the JSON string.

Rather, map the db data into the corresponding object (entity?), and then serialize it into JSON.

You can use the Javascript Serializer. I also use the JayRock library.

answered Apr 4, 2013 at 13:00

Alberto De Caro

5,2139 gold badges50 silver badges77 bronze badges

Collectives™ on Stack Overflow

jquery how to write proper json object in c#

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related