Using onclick function in javascript tags

Question

I have a function openWindow(word) that gets called when a button is clicked. This function opens a new window, prints the word and shows a button called do. The openWindow function works up until the onclick in its tag is supposed to find the do function. My problem is that onclick never seems to find my do function. What do I do?

My do function:

 function do() {
   alert("Life is what you make of it");
 }

My openWindow function:

 function openWindow(word) {
      myWindow.document.write(word);
      myWindow.document.write('<body>'); 
      myWindow.document.write('<input type="button" value="Do" onclick="do()">');
      myWindow.document.write('</body>');
     }      
  }

My html code to open window:

<body>
   <input type="button" value="Submit" onclick="openWindow()">
</body>

'do' is a reserved keyword in JS. How is that you are not getting error? I tried in jsfiddle. I get unexpected token error. — Adisesha
– Adisesha, Commented Apr 4, 2013 at 18:53

James Hill · Accepted Answer · 2013-04-04 18:54:41Z

1

do() does not exist in the new popup window. I suggest using this approach:

myWindow.document.write('<body>'); 
myWindow.document.write('<input type="button" value="Do" onclick="do()">');
myWindow.document.write('</body>');

// Define "Do" in the context of the new window
// Note: I have changed "do" to "Do" because "do" is a reserved word in JS
myWindow.Do = Do;

Here is a working fiddle (make sure are not blocking popups).

edited Apr 4, 2013 at 18:54

answered Apr 4, 2013 at 18:42

James Hill

62.2k22 gold badges150 silver badges166 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Oded · Accepted Answer · 2013-04-04 18:41:38Z

0

The do function is not part of the new window you have created, so it cannot be found.

You need to include it, either through a linked JavaScript file, or inline.

answered Apr 4, 2013 at 18:41

Oded

501k102 gold badges900 silver badges1k bronze badges

Comments

Blunderfest · Accepted Answer · 2013-04-04 18:44:06Z

0

Your new window doesn't have the function definition to know what to do when "do()" is called.

If you simply want an alert with a button:

myWindow.document.write('<input type="button" value="Do" onclick="alert('Life is what you make of it')";

Otherwise, James Hill has the way to go.

answered Apr 4, 2013 at 18:44

Blunderfest

1,8542 gold badges28 silver badges46 bronze badges

Collectives™ on Stack Overflow

Using onclick function in javascript tags

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related