Pass value from loop to javascript function

Question

I have following code:

var storedNames = JSON.parse(localStorage.name); 
var mytable = "<table> cellpadding=\"0\" cellspacing=\"0\"><tbody><tr>"; 
for (var i = 0; i < storedNames.length; i++) {   
  if (i % 2 == 1 && i != 1) {
     mytable += "</tr><tr>";   
  }

    mytable += "<td>" + storedNames[i].name +" "+ storedNames[i].email+"</td><td><img id='arrow' src='arrow.png' height='20' width='20' onclick='redirectToDetail();' ></td></tr>"; 
} 

mytable += "</tbody></table>";

document.write(mytable);

here, in redirectToDetail function i want to i value . How can I pass this? Any idea? thank u in advance

var mytable = "<table> cellpadding=\"0\" cellspacing=\"0\"><tbody><tr>"; or var mytable = "<table cellpadding=\"0\" cellspacing=\"0\"><tbody><tr>";? — Narek
– Narek, Commented Apr 9, 2013 at 7:32
@FeistyMango this is not answer, just wrong syntax notice. — Narek
– Narek, Commented Apr 9, 2013 at 7:35
@FeistyMango do we speak about same thing? :) Check symbol after <table — Narek
– Narek, Commented Apr 9, 2013 at 7:43
@Narek Ahh, I see what you mean. I thought you were making an issue of the quotes. Doh — Matthew Cox
– Matthew Cox, Commented Apr 9, 2013 at 7:45

bipen · Accepted Answer · 2013-04-09 07:30:08Z

1

try this

 mytable += "<td>" + storedNames[i].name +" "+ storedNames[i].email+"</td><td><img id='arrow' src='arrow.png' height='20' width='20' onclick='redirectToDetail(\'"+ i +"\');' ></td></tr>";

and take that in redirectToDetail

 function redirectToDetail(val){
     alert(val);
  }

answered Apr 9, 2013 at 7:30

bipen

36.6k9 gold badges51 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matthew Cox · Accepted Answer · 2013-04-09 07:45:06Z

Just add the value as a literal constant that is passed to the onclick event and you are home free. In addition, I would strongly encourage you to consider using an array and joining the strings as you will yield much better performance particularly in IE.

var storedNames = JSON.parse(localStorage.name); 
var mytable = ['<table cellpadding="0" cellspacing="0"><tbody><tr>'];
for (var i = 0; i < storedNames.length; i++) {   
  if (i % 2 == 1 && i != 1) {
     mytable.push("</tr><tr>");   
  }
  mytable.push('<td>' + storedNames[i].name + ' ' + storedNames[i].email + '</td><td><img id="arrow" src="arrow.png" height="20" width="20" onclick="redirectToDetail(' + i + '"></td></tr>"');
} 

mytable.push("</tbody></table>");

document.write(mytable.join());

Now you can declare you onclick function like so:

function redirectToDetail(value) {
   //do stuff with the value
}

muneebShabbir · Accepted Answer · 2013-04-09 07:29:58Z

0

try this

onclick='redirectToDetail(\'"+i+"\')

answered Apr 9, 2013 at 7:29

muneebShabbir

2,5384 gold badges30 silver badges49 bronze badges

Comments

999k · Accepted Answer · 2013-04-09 07:30:35Z

0

I think this will do. check it.

mytable += "<td>" + storedNames[i].name +" "+ storedNames[i].email+"</td><td><img id='arrow' src='arrow.png' height='20' width='20' onclick='redirectToDetail(" + i + ");' ></td></tr>";

answered Apr 9, 2013 at 7:30

999k

6,6452 gold badges31 silver badges32 bronze badges

2 Comments

999k Over a year ago

Ok. I think you noticed this unwanted > in var mytable = "<table> cellpadding=\"0\"

999k Over a year ago

Also in your code pairing issue for tag <tr>. For eg if storedNames.length == 0

Collectives™ on Stack Overflow

Pass value from loop to javascript function

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related