replace in javascript not replacing

Question

so here is the code

var searchValue = "Dans-Test";

if ( searchValue.indexOf('-') >= 0 ){
searchValue.replace('-', ' ');  
console.log("reached here");
} else {
console.log("no -");
}

console.log(searchValue);

searchValue is still outputting Dan-Test and not Dan Test, why?

it does console log reached here so the if statement is correct

thanks

Returns a new string with some or all matches of a pattern replaced by a replacement. The pattern can be a string or a RegExp, and the replacement can be a string or a function to be called for each match. developer.mozilla.org/en/docs/JavaScript/Reference/… — Ron van der Heijden
– Ron van der Heijden, Commented Apr 10, 2013 at 8:32

elclanrs · Accepted Answer · 2013-04-10 08:31:33Z

5

replace doesn't modify the original string, it's non-mutable:

searchValue = searchValue.replace('-', '');

answered Apr 10, 2013 at 8:31

elclanrs

94.2k21 gold badges137 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

youngplayer · Accepted Answer · 2013-04-10 08:34:54Z

0

Additionally, the replace function only replace the first matched character.

answered Apr 10, 2013 at 8:34

youngplayer

431 silver badge6 bronze badges

Collectives™ on Stack Overflow

replace in javascript not replacing

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related