Counting up array results from mysql

Question

i've got a problem with my php script. I want to check my script if there is anything in array and if there's no to echo a message but when array is empty it just don't echo nothing.

That's my code:

    include("mysql_connect.php");
$name = $_POST['playerName'];
$users = mysql_query('SELECT * FROM playerdata WHERE username LIKE "'.$name.'%"');
        if($name==""){
        echo 'Type in player name!';
    }else{
while($usersList= mysql_fetch_assoc($users)){
    if(!array_count_values($usersList)){
        echo 'Player not found';
    }else{
        echo $usersList['username'].', ';
    }
}//While end.
}//If name is empty end.

WHERE username LIKE "'.$name.'%"'); is missing a ' before the variable — David Starkey
– David Starkey, Commented Apr 10, 2013 at 16:35

msfoster · Accepted Answer · 2013-04-10 17:10:30Z

1

As mentioned, you have to check for rows before the loop.

$rows = mysql_num_rows($users);
if($rows==0) echo "No rows..";
else {
  foreach() {

answered Apr 10, 2013 at 17:10

msfoster

2,5721 gold badge19 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Akash · Accepted Answer · 2013-04-10 17:17:33Z

The problem seems is that, if a user enters a invalid name, the while loop does not execute, as the query simply cannot find any rows, the code should be as follows

include("mysql_connect.php");
$name = $_POST['playerName'];

if( $name === "" ){
    echo 'Type in player name!';
} else {
    $users = mysql_query('SELECT * FROM playerdata WHERE username LIKE "'.$name.'%"');

    if ( mysql_num_rows($users) == 0) {
        echo "Invalid Player name provided";
    } else {
        while($usersList= mysql_fetch_assoc($users)){
        {
            echo $usersList['username'].', ';
        } //While end.
    }
}//empty name

Notes:

I have re-formatted the code as it looked ugly
The query is executed only if a user provides some text for name, why execute the query when the name is empty !

choppingblock · Accepted Answer · 2013-04-10 16:44:55Z

0

instead of

if(!array_count_values($usersList)){

use

if(empty($usersList)){

answered Apr 10, 2013 at 16:44

choppingblock

1101 gold badge1 silver badge9 bronze badges

Comments

richelliot · Accepted Answer · 2013-04-10 16:50:50Z

0

Your while loop wont be executed if $users is empty, so the condition:

if(!array_count_values($usersList)){
        echo 'Player not found';
   }

will never be met because it is contained in a loop which will never run.

answered Apr 10, 2013 at 16:50

richelliot

5762 gold badges11 silver badges30 bronze badges

6 Comments

Kamil Oczkowski Over a year ago

No because $name is seperate value

richelliot Over a year ago

Try adding: echo 'here'; above if(!array_count_values($usersList)){ and see if the loop is being executed

Kamil Oczkowski Over a year ago

It begins but when it's empty it doesn't do anything

richelliot Over a year ago

so does it echo 'here' when you use a name that isnt in the database?

Kamil Oczkowski Over a year ago

No it doesn't do anything. :/

|

Collectives™ on Stack Overflow

Counting up array results from mysql

4 Answers 4

Comments

Comments

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related