Nested foreach() in PHP

Question

I need some help with nested foreach.

This is my code:

$program = $_POST['program'];
$licence = $_POST['licence'];
    foreach($program as $p){
        foreach($licence as $l){
mysql_query("INSERT INTO programs (pcname, program, licence) VALUES ('". $pcname ."', '". $p ."', '". $l ."')");

  }
}

This doesn't work and I know why. But I cannot find a way to fix the issue. The issue is, that it is going through all the values in the inside foreach, then is is going through them all, all over again for the next value in the outside foreach.

This probably wasn't explained very well, but hopefully you can understand what I am doing in trying to achieve, and to help me out.

Is the $program/$licence an array? I think not, as the $_POST values are strings. — Voitcus
– Voitcus, Commented Apr 11, 2013 at 19:27

Marc B · Accepted Answer · 2013-04-11 19:26:38Z

2

Assuming your two arrays have a 1:1 mapping between their elements, say. 5 each, then your nested loops are going to produce 25 insert calls. You need to use the keys from one array to refer to the other:

foreach($program as $key => $p) {
    $l = $license[$key];
    mysql_query(...);
}

and note that you are WIDE open for sql injection attacks.

answered Apr 11, 2013 at 19:26

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Melloorr Over a year ago

This worked like a charm, worked exactly as I wanted it to, and yes I know I am open to attacks, but this is only for local use, and I will be added this kinda stuff in once it has all the functionality. Thanks again for your answer :)

AlucardTheRipper Over a year ago

$l = array_shift(license); If the keys aren't the same.

aprohl5 · Accepted Answer · 2013-04-11 19:37:46Z

0

correct me if I am wrong but I believe your problem would be solved by simply moving your query statement to after the first for loop...

answered Apr 11, 2013 at 19:37

aprohl5

991 gold badge1 silver badge8 bronze badges

Collectives™ on Stack Overflow

Nested foreach() in PHP

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related