passing string value to sql server

Question

I am using SQL to retrive data from SQL-Server in C#, like below:

var cmd = new SqlCommand(
    "select *, replace(trucknocn, char(10), '') trucknocn1 from deliverylist  where deliverydate=@scantime", sqlCon);             
cmd.Parameters.Add("@scantime", SqlDbType.VarChar, 10).Value
    = Calendar1.SelectedDate.ToString("yyyy-MM-dd");            

da.SelectCommand = cmd;

My problem is that am I correct in doing this to avoid regional setting problems for my client application machine. Anything that I can do to totally avoid the regional setting problem?

Thanks

When you say regional setting problem, are you talking about different time zones? — Mike Perrenoud
– Mike Perrenoud, Commented Apr 12, 2013 at 10:19

Cyril Gandon · Accepted Answer · 2013-04-12 10:21:09Z

5

Is deliverydate a varchar? I don't think so.
You can just add the parameter as DateTime:

cmd.Parameters.Add("@scantime", SqlDbType.DateTime).Value = Calendar1.SelectedDate;

Then all the regional setting problem are gone, since there is no string->Date->string conversion, and the comparaison are made base on the real date value, not just a string representation.

answered Apr 12, 2013 at 10:21

Cyril Gandon

17.1k15 gold badges84 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mayeed · Accepted Answer · 2013-04-12 12:59:42Z

0

If deliverydate is varchar type then I did not find any problem in your code,

But if deliverydate is datetime then change the code like following -

your's

cmd.Parameters.Add("@scantime", SqlDbType.VarChar, 10).Value = Calendar1.SelectedDate.ToString("yyyy-MM-dd");

New Code:

cmd.Parameters.Add("@scantime", SqlDbType.DateTime).Value = Calendar1.SelectedDate;

answered Apr 12, 2013 at 12:59

Mayeed

8001 gold badge7 silver badges20 bronze badges

Collectives™ on Stack Overflow

passing string value to sql server

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related