Rspec: How to assign instance variable in controller spec

Question

class TestController < AplicationController
  #....

  private

  def some_method
    unless @my_variable.nil?
      #...
      return true
    end
  end
end

I want to test some_method directly in controller spec:

require 'spec_helper'

describe TestController do
  it "test some_method"
    phone = Phone.new(...)
    controller.assign(:my_variable,phone) #does not work
    controller.send(:some_method).should be_true
  end
end

How I can set TestController instance variable @my_variable from controller spec?

Community · Accepted Answer · 2017-05-23 12:34:41Z

When testing private methods in controllers, rather than use send, I tend to use an anonymous controller due to not wanting to call the private method directly, but the interface to the private method (or, in the test below, effectively stubbing that interface). So, in your case, perhaps something like:

require 'spec_helper'

describe TestController do
  controller do
    def test_some_method
      some_method
    end
  end

  describe "a phone test with some_method" do

    subject { controller.test_some_method }

    context "when my_variable is not nil" do
      before { controller.instance_variable_set(:@my_variable, Phone.new(...)) }
      it { should be_true }
    end

    context "when my_variable is nil" do
      before { controller.instance_variable_set(:@my_variable, nil) } 
      it { should_not be_true } # or should be_false or whatever
    end     
  end
end

There's some good discussion on the issue of directly testing private methods in this StackOverflow Q&A, which swayed me towards using anonymous controllers, but your opinion may differ.

ReWrite · Accepted Answer · 2017-11-22 18:17:21Z

5

instance_eval is a relatively clean way to accomplish this:

describe TestController do
  it "test some_method" do
    phone = Phone.new(...)
    controller.instance_eval do
      @my_variable = phone
    end
    controller.send(:some_method).should be_true
  end
end

In this case, using do...end on instance_eval is overkill, and those three lines can be shortened to:

controller.instance_eval {@my_variable = phone}

answered Nov 22, 2017 at 18:17

ReWrite

2,7181 gold badge22 silver badges14 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:55:07Z

2

I don't think you want to access an instance variable from your spec controller, as the spec should test the behaviour, but you can always stub the private method. In your case it should be something like this (in this example it doesn't make so much sense):

describe TestController do
  it "test some_method"
    phone = Phone.new(...)
    controller.stub(:some_method).and_return(true)
    controller.send(:some_method).should be_true
  end
end

If this is not what you are looking for take a look at this: How to set private instance variable used within a method test?

edited May 23, 2017 at 11:55

CommunityBot

11 silver badge

answered Apr 15, 2013 at 0:05

Alex Falke

2,2482 gold badges15 silver badges11 bronze badges

Collectives™ on Stack Overflow

Rspec: How to assign instance variable in controller spec

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related