jquery if statement not functioning correctly

Question

I was writing a very simple function but can't get the if statement to work correctly.

$("#supplyRequestTextbox-clients").live("blur", function() {
    var textboxValue = $(this).val().replace(/\d+/g, '').replace(" ", "");
    if (textboxValue == "NO ACCOUNT") {
        $(".controlBarTextboxNoAccount").fadeIn("fast");
    }
});

The value in the input #supplyRequestTextbox-clients represents a client and is organized like this:
id# FirstName LastName email phone An example: 000001 John Doe [email protected] 123-456-7890

When no account is found, the string appears exactly like this: 000906 NO ACCOUNT

In my function I strip the digits and first space, then check to see if it works in my if statement. I have alerted textboxValue and it is passing correctly, but no matter that textboxValue is, the if statement never fires.

Simon M · Accepted Answer · 2013-04-16 03:29:21Z

4

Change the if condition to:

if(textboxValue.indexOf("NO ACCOUNT") !== -1)

indexOf("NO ACCOUNT") finds "NO ACCOUNT" within textboxValue, if it can't find it -1 is returned. So this will be true if "NO ACCOUNT" is anywhere in your string.

answered Apr 16, 2013 at 3:29

Simon M

2,9412 gold badges24 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

radleybobins Over a year ago

YES! Thank you, this worked perfectly. I can't believe I didn't try something like this earlier, been staring at it too long. Thanks so much for your help!

Simon M Over a year ago

@radleybobins No worries, happens to everyone :) A small issue I just thought of: if some nasty user enters NO ACCOUNT as their name for whatever reason, it might cause problems. But that seems quite unlikely...

Niet the Dark Absol · Accepted Answer · 2013-04-16 03:19:30Z

2

Use == for comparisons. You are assigning a truthy value, so the statement always fires.

answered Apr 16, 2013 at 3:19

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

3 Comments

radleybobins Over a year ago

yes, i can't believe I missed that. now the if statement never fires, though, any ideas?

Niet the Dark Absol Over a year ago

Are you sure there are no more spaces in the value? Have you tried not replacing the digits and space and just checking for 000906 NO ACCOUNT?

radleybobins Over a year ago

I like where you head is at, but there are multiple id numbers depending on which school I am working with...so it could be 000907 or 000908, i'd like to keep the maintenance to a minimum when I add extra schools, so I don't want to add an extra OR each time I add a school, i'd rather just strip the id number off

Claudio Redi · Accepted Answer · 2013-04-16 03:24:57Z

1

Change your if condition to

if (textboxValue == "NO ACCOUNT")

If you do

if (textboxValue = "NO ACCOUNT")

You're actually assigning "NO ACCOUNT" to textboxValue and evaluating the result as bool.

edited Apr 16, 2013 at 3:24

answered Apr 16, 2013 at 3:19

Claudio Redi

68.6k15 gold badges138 silver badges161 bronze badges

4 Comments

radleybobins Over a year ago

so now it never works, no matter what textboxValue is, any ideas?

Blender Over a year ago

@radleybobins: You're getting rid of the spaces as well, so it's probably like NOACCOUNT. See what the value of the textbox actually is.

radleybobins Over a year ago

@blender when I alert textboxValue or append it into a testing box it appears correctly with the proper spaces. The first space only is removed.

Claudio Redi Over a year ago

@radleybobins: please see this example. Your code now should work unless there is something else you're not telling us.

Jim O'Connell · Accepted Answer · 2013-04-16 03:29:29Z

0

Try doing this:

$("#supplyRequestTextbox-clients").live("blur", function() {
    var textboxValue = $(this).val().replace(/\d+/g, '').replace(" ", "");

    // check what textboxValue evaluates to:
    alert(textboxValue);

if (textboxValue == "NO ACCOUNT") {
    $(".controlBarTextboxNoAccount").fadeIn("fast");
}
});

answered Apr 16, 2013 at 3:29

Jim O'Connell

812 silver badges3 bronze badges

Comments

Francis Kim · Accepted Answer · 2013-04-16 03:30:43Z

0

Use == for comparisons as Kolink suggest.
You are replacing " " with "", IE. removing all spaces so your if statement will never return true.

answered Apr 16, 2013 at 3:30

Francis Kim

4,2954 gold badges39 silver badges51 bronze badges

Collectives™ on Stack Overflow

jquery if statement not functioning correctly

5 Answers 5

2 Comments

3 Comments

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

3 Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related