Passing a Javascript or PHP Variable to another page

Question

I have been trying to figure this out for two days and have had no luck.I am using PHP with Javascript and I am trying to access a Javascript variable on another Page.

Here is my Javascript code which is only alerting the user what taskID is...

<script>
function myFunction(taskID)
{
alert("Task #" + taskID);

}
</script>

Here is my PHP

//select all tasks for this report
            $tasks = mysqli_query($conn,"SELECT taskID, hoursSpent, workDone, plannedTasks FROM Tasks where reportID = $report_id AND projID = $proj_id");
            $task_count = 1;
            while($row1 = mysqli_fetch_array($tasks))
            {
                $taskID = $row1['taskID'];
                //display the task information
                echo "<strong id='tasks'>Task #" . $task_count . "</strong>";
                echo " - <a href = '#' onclick ='myFunction($taskID)'>Edit</a><br>";


                echo "Hours Spent: " . $row1['hoursSpent'] . "<br><br>"; 
                echo "Accomplished: <br>" . $row1['workDone'] . "<br><br>";
                echo "Planned for Next week: <br>" . $row1['plannedTasks'] . "<br>";
                echo "<br>";
                $task_count++;
            }

how can i pass that taskID to another page so i can edit the task information?

Thanks!

easiest as a GET variable: "mysite.com/otherpage.php?taskID=3" — winkbrace
– winkbrace, Commented Apr 16, 2013 at 17:14
There are multiple solutions, like: 1) in URL (eg. using query parameter), 2) in cache, 3) in pushState/onpopstate states, 4) in hash (theoretically part of URL, but not visible to server), or even in 5) session, 6) localStorage etc. - it all depends what exactly you are trying to achieve. I would however stick to using URL for this, if your pages are pretty static and you want to give the ability to open more than one at once. — Tadeck
– Tadeck, Commented Apr 16, 2013 at 17:22

Elias Van Ootegem · Accepted Answer · 2013-04-16 17:24:15Z

2

Just change this:

echo " - <a href = '#' onclick ='myFunction($taskID)'>Edit</a><br>";

To

echo " - <a href = 'editTask.php?id=".$taskID."'>Edit</a><br>";

And you're there. Just make sure that, in the editTask.php file, you check the id:

$editID = (int) $_GET['id'];//<-- $editID will hold an int, that is the id of the record the user wanted to edit.

Quite apart from that: good to see you're using an up-to-date extension for mysql. Nevertheless, code like this:

mysqli_query($conn,"SELECT taskID, hoursSpent, workDone, plannedTasks FROM Tasks where reportID = $report_id AND projID = $proj_id");

Will leave you vulnerable for injection attacks. Please do look into prepared statements.

$tasks = mysqli_query($conn, 'SELECT taskID, hoursSpent, workDone, plannedTasks FROM Tasks WHERE reportID = ? AND projID = ?');
mysqli_stmt_bind_param($tasks, 'i', $reportID);//replace i with s if should be a string etc...

Once your building queries based on client side data (which you will be doing with this: using the url to get the id...), it's the easiest way to protect yourself against a very common threat.

check this link
This one
And of course, this one to understand what injection is

edited Apr 16, 2013 at 17:24

answered Apr 16, 2013 at 17:17

Elias Van Ootegem

76.7k10 gold badges123 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1536365 Over a year ago

Thank you so much! I was overlooking it and now I feel really dumb. Have been looking into the prepared statements and already have two prepared insert statements. Will change the select queries to be prepared as well. Thanks again!

Elias Van Ootegem Over a year ago

@user1536365: Glad I could help... though I appreciate your comment, the SO way of thanking somebody is by accepting the answer (clicking the large tick next to the answer)... you'll get some rep for it, too

mplungjan · Accepted Answer · 2013-04-16 17:18:02Z

0

Like this

<script>
function myFunction(taskID) {
  location="nextpage.php?task="+taskID;
  return false;

}
</script>



echo " - <a href = '#' onclick ='return myFunction("'.$taskID.'")'>Edit</a>

Or simpler

echo " - <a href='nextpage.php?task='.$taskID.'">Edit</a>

answered Apr 16, 2013 at 17:18

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Collectives™ on Stack Overflow

Passing a Javascript or PHP Variable to another page

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related