how can I hide a part of javascript from IE

Question

This is my javascript function to open a jquery dialog.

   ('#dialog').append(iframe).appendTo("body").dialog({
          autoOpen: false,
          modal: true,
          resizable: false,
          show: 'slide',        
          width: 800,       
          height: 700,        
         close: function() {           
    }   
});             
$('#dialog_click').click("callback",function() {            
   $('#dialog').dialog('open');                 
   return false;
});

How can I hide the part show: 'slide, from IE ?

Your question seems like a second-generation question. For example, the real problem is that you are having trouble with slide in IE, which is why you are asking to remove it in IE. You might be able to solve the original problem if you ask. — Fenton
– Fenton, Commented Apr 18, 2013 at 11:47
Are you sure you want to do this? Is this because of a particular problem in older versions of IE? What versions are you testing? Have you tried it in IE9 and IE10? They're actually pretty good browsers (especially IE10). — Spudley
– Spudley, Commented Apr 18, 2013 at 12:53

Hilmi · Accepted Answer · 2013-04-18 11:47:07Z

2

var options = {
          autoOpen: false,
          modal: true,
          resizable: false,       
          width: 800,       
          height: 700,        
         close: function() {           
    }   
};
if ( ! $.browser.msie){
  options ['show'] = 'slide';
}

$('#dialog').append(iframe).appendTo("body").dialog(options);

answered Apr 18, 2013 at 11:47

Hilmi

3,4316 gold badges30 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hilmi Over a year ago

I'm glad that i could help.

Spudley Over a year ago

beware: the $.browser feature in jQuery is deprecated, and has been removed entirely from the more recent versions. It is not recommended. (in fact, browser detection in general is not recommended for most use cases)

PSR · Accepted Answer · 2013-04-18 11:47:24Z

2

try this

if ( ! $.browser.msie){
  $( "#dialog" ).dialog( "option", "show", "slide" )
}

answered Apr 18, 2013 at 11:47

PSR

40.4k43 gold badges115 silver badges154 bronze badges

1 Comment

Spudley Over a year ago

beware: the $.browser feature in jQuery is deprecated, and has been removed entirely from the more recent versions. It is not recommended. (in fact, browser detection in general is not recommended for most use cases)

Arun P Johny · Accepted Answer · 2013-04-18 11:58:26Z

2

jquery has removed support for jQuery.browser.msie from version >= 1.9

so

var opts = {
    autoOpen : false,
    modal : true,
    resizable : false,
    show : 'slide',
    width : 800,
    height : 700,
    close : function() {
    }
};
if (!/msie/.test(window.navigator.userAgent)) {
    opts.show = 'slide';
}

('#dialog').append(iframe).appendTo("body").dialog(opts);
$('#dialog_click').click("callback", function() {
    $('#dialog').dialog('open');
    return false;
});

answered Apr 18, 2013 at 11:58

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Comments

Chris Dixon · Accepted Answer · 2013-04-18 12:18:08Z

2

$('#dialog').append(iframe).appendTo("body").dialog({
          autoOpen: false,
          modal: true,
          resizable: false,       
          width: 800,       
          height: 700,        
         close: function() {           
    } 
});

if(!$.browser.msie) {
     $( "#dialog" ).dialog( "option", "show", "slide" );
}

edited Apr 18, 2013 at 12:18

answered Apr 18, 2013 at 11:47

Chris Dixon

9,1777 gold badges38 silver badges69 bronze badges

2 Comments

Mohamed Over a year ago

I tried this but in my case it is not working. The dialog is not opening when I added this. Is any other problem with the code

Spudley Over a year ago

beware: the $.browser feature in jQuery is deprecated, and has been removed entirely from the more recent versions. It is not recommended. (in fact, browser detection in general is not recommended for most use cases)

Andrea Ligios · Accepted Answer · 2013-04-18 12:45:17Z

There are several workarounds for this (conditional comments for the whole script, altering the property later, etc) but noone has posted a solution that does EXACTLY what you asked: excluding a portion of javascript only in IE.

Then take a look at this:

   ('#dialog').append(iframe).appendTo("body").dialog({
          autoOpen: false,
          modal: true,
          resizable: false,

        /*@cc_on @*/
        /*@if (true)

        @else @*/
          show: 'slide',        
        /*@end @*/

          width: 800,       
          height: 700,        
         close: function() {           
    }   
});             
$('#dialog_click').click("callback",function() {            
   $('#dialog').dialog('open');                 
   return false;
});

IE won't include show: 'slide',, while non-IE browsers won't read the Conditional Compilation Statements , so the condition will fall in the (not-commented) else part.

Read more on Conditional Compilation Statements

vittore · Accepted Answer · 2013-04-18 11:50:41Z

There is several thing you can do.

First there are conditional comments , ie

<!--[if !IE ]>
    <script>
       $('#dialog').append(iframe).appendTo("body").dialog({
         autoOpen: false,
         modal: true,
         resizable: false,
         show: 'slide',        
         width: 800,       
         height: 700,        
         close: function() {           
         }   
       });             
       $('#dialog_click').click("callback",function() {            
         $('#dialog').dialog('open');                 
         return false; 
       }); 
    </script>
<![endif]-->

Or you can check jquery browser variable , as other guys are pointing.

Also if you are going this way, and you really want to target old version of IE you can use some functions specific to it ( like attachEvent )

Collectives™ on Stack Overflow

how can I hide a part of javascript from IE

6 Answers 6

2 Comments

1 Comment

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

1 Comment

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related