PHP Infinite While Loop, Unknown Cause

Question

<?php
$i=1;
while ($i<=$totalpages) {
    if (($i>=($page-5) && $i<=($page+5) && $i<$totalpages) || $i==1 || ($i+1>$totalpages)) {

        echo "<td><a href=\"search.php?page=$i\">";
        if ($i=$page) {
        echo "<strong>  $i  </strong>";
        }
        if ($i!=$page) {
        echo "  $i  ";
        }
        echo "</a></td>";
        }
    $i++;
    }

?>

Trying to build a webpage that ouputs some search values neat the bottom of the page, however I keep getting an infinite loop. I've no Idea about what's causing it, and would like someone elses insight into the problem at hand.

Your if-statement is quite complicated. I would recommend replacing it with something like: if(CheckSomeCondition($i, $page, $totalPages)){ ... }, then do the actual logic of the if-check in a more readable fashion in that method (that would probably make it easier for you to find the problem yourself, too). — Kjartan
– Kjartan, Commented Apr 22, 2013 at 11:24

chandresh_cool · Accepted Answer · 2013-04-22 11:04:56Z

2

Your if condition has a problem

Change

$i =1

with

$i==1

answered Apr 22, 2013 at 11:04

chandresh_cool

11.9k3 gold badges32 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Stuart Siegler · Accepted Answer · 2013-04-22 11:05:25Z

1

You have a number of places that you reset $i, inadvertently I assume

$i=1

and

$i=$page

replace them with ==

answered Apr 22, 2013 at 11:05

Stuart Siegler

1,7364 gold badges30 silver badges40 bronze badges

1 Comment

DarkBee Over a year ago

Well, it resets the variable and returns true as the value has been set succesfully

Navnath Godse · Accepted Answer · 2013-04-22 11:07:55Z

0

<?php
        $i=1;
        while ($i<=$totalpages) {
            if (($i>=($page-5) && $i<=($page+5) && $i<$totalpages) || $i == 1|| ($i+1>$totalpages)) {

                echo "<td><a href=\"search.php?page=$i\">";
                if ($i == $page) {
                echo "<strong>  $i  </strong>";
                }
                if ($i!=$page) {
                echo "  $i  ";
                }
                echo "</a></td>";
                }
            $i++;
            }
?>

Changes in 1st and second if condition.
1) $i == 1
2) $i == $page

answered Apr 22, 2013 at 11:07

Navnath Godse

2,2252 gold badges25 silver badges33 bronze badges

2 Comments

Pete Spalding Over a year ago

Yup, that's fixed it, thanks for pointit out my own stupidity. :)

Navnath Godse Over a year ago

Most welcome, always take a time while deciding a conditions it will save your time and make your software bug free.

MadDokMike · Accepted Answer · 2013-04-22 11:11:35Z

0

is there a reason why this can not be accomplished using a for loop ? While loops are always risky and easy to cause problems if there is a scenario to cause to loop for ever.

eg.

for ($i = 0; $i<=$totalpages; $i++){
 // do something
}

answered Apr 22, 2013 at 11:11

MadDokMike

1825 bronze badges

2 Comments

DarkBee Over a year ago

He has multiple conditions

MadDokMike Over a year ago

TRUE but he could still do this with a for loop, all that's happening is he is looping through a list of page numbers and making the active page number bold

Agus · Accepted Answer · 2013-04-22 11:15:19Z

0

There is some issues in the conditions

first: the

|| $i=1||

allways return true. Change for

|| $i==1||

Second: The same case of adobe

if ($i=$page) //Allways return try is assignation operation

Change to:

if ($i==$page)

answered Apr 22, 2013 at 11:15

Agus

1,6242 gold badges23 silver badges48 bronze badges

Collectives™ on Stack Overflow

PHP Infinite While Loop, Unknown Cause

5 Answers 5

Comments

1 Comment

2 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

2 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related