Linq filter out rows with null or string.empty

Question

I have a linq query where I am reading all the lines of a CSV the file has extra rows at the end that have no data. I need to filter out those rows so that it only has the rows with data I am using the following query but it still returns like 8000 rows and there are only 52 with data in them.

   var query =
            from c in
                (from line in File.ReadAllLines(excelFile)
                    let transactionRecord = line.Split(',')
                    select new Transaction()
                    {
                        TxnId = transactionRecord[12],

                    })
            where c.TxnTax != string.Empty
            select c;

Not relaly sure why this is happening? Doe anyone have any ideas?

Why don't you show some example data? Difficult to know what's wrong without it. — spender
– spender, Commented Apr 26, 2013 at 13:33
Where is TxnTax being assigned? It looks like you've got an IEnumerable<Transaction> with TxnId assigned that you are iterating through, but I don't see where you assign TxnTax anywhere. It could be a null value. — Chris
– Chris, Commented Apr 26, 2013 at 13:37
maybe from line in File.ReadAllLines(excelFile) where !string.IsNullOrWhitespace(line) — musefan
– musefan, Commented Apr 26, 2013 at 13:38
Are you actually even setting c.TxnTax? If not, then it will be null for all results anyway, so no point testing that. I believe my other comment is the solution anyway — musefan
– musefan, Commented Apr 26, 2013 at 13:39

polkduran · Accepted Answer · 2013-04-26 13:49:07Z

2

This will give an IEnumerable containing the lines (string[]) having at least one column with data

IEnumerable<string[]> data = 
    from line in System.IO.File.ReadAllLines("")
    let lineData = line.Split(',')
    where lineData.Any(cell => !string.IsNullOrEmpty(cell))
    select lineData;

answered Apr 26, 2013 at 13:49

polkduran

2,56024 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Spafa9 · Accepted Answer · 2013-04-26 13:50:36Z

2

This worked

var query =
                    from c in
                        (from line in File.ReadAllLines(excelFile)
                            let transactionRecord = line.Split(',')
                            select new Transaction()
                            {
                                TxnId = transactionRecord[12],

                            })
                    where ((string.IsNullOrEmpty(c.TxnId) == false) && (c.TxnId != "Billing Information|Transaction ID"))
                    select c;

answered Apr 26, 2013 at 13:50

Spafa9

7543 gold badges15 silver badges30 bronze badges

Collectives™ on Stack Overflow

Linq filter out rows with null or string.empty

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related