Proper variable scope in windows batch script

Question

I cant figure out this variable scope.. heres the code. I've been reading around but cant seem to nail it. I want to copy a file 4 times and concatenate a name every time expanding the name of the file. it will copy: Cow, Cow Cow, Cow Cow Cow, etc.

set "hash = Cow"
call:filecreate "Cow","%hash%"

:filecreate
set "name = %~1"
for /l %%C in (1,1,4) do (
for /f %%a in ('xcopy "%filez%" "%desktop%" /H /Y /R /F') do (
ren "%desktop%\system.ini" "!name!"
)
set "name = !name! %~2"
)
goto:eof

Magoo · Accepted Answer · 2013-04-30 07:58:19Z

3

SPACES are significant in SET statements.

set var = something

will set a variable "var " to " something"

set var=something

will set a variable "var" to "something"

(also beware - having CALLed :filecreate, batch wil then execute :filecreate a second time because it does NOT recognise a label as 'end of procedure'. You need an explicit GOTO :EOF after the CALL if you only want the procedure to be executed once)

answered Apr 30, 2013 at 7:58

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Proper variable scope in windows batch script

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related