Using two different objects of the same type in different classes in Java

Question

I am writing a program in Java which is supposed to be like a student administration with different lists of students, subjects, teachers and so on. The program shall among others include one general subjectlist and one subjectlist for each student. The problem is that when I create two different subjects and add it to the general subjectlist and later on find one of these and add it to the student subjectlist, the student subjectlist contains both of these subjects.

I have searched the web but it is not so easy to know what to look for!

I am writing the datastructure myself.

My code looks something like this:

public class Subject() {
    Subject next; 
    //constructor with parameters
}

public class Subjectlist() {
    private Subject first;

    //methods for adding to list, deleting, find and so on
}

public class Participation {
    Subjectlist subjects; 

    public Participation() {
        subjects = new Subjectlist();
    }
}

public class Student() {
    Participation participation;
    public Student(paramters) {
        participation = new Participation();
    }

public class mainclass() {
    public static void main(String [] args) {
        Subjectlist subjectlist = new Subjectlist(); 
        Studentlist students = new Studentlist(); 

        Student student = new Student(parameters);
        students.addToList(student);

        Subject subject1 = new Subject(parameters);
        Subject subject2 = new Subject(parameters);

        subjectlist.addToList(subject1);
        subjectlist.addToList(subject2);

        Subject subject = subjectlist.find(subjectid); //Finds the subject with an ID given in the constructor

        student.participation.subjects.addToList(subject);

        //Now student.participation.subjects contains both subject1 and subject2
    }

}

Any help would be much appreciated!

EDIT:

This is the find and addToList methods:

public String addToList(Subject new) {
    Subject pointer = first;          //Subject first is declared in the class
    if(new == null) {
        return "The subject was not added.";
    }
    else if (first == null) {
        first = new;
        return "The subject was added";
    }
    else { 
        while ( pointer.next != null ) 
            pointer = pointer.next; 
        pointer.next = new;
        return "The subject was added";
    }
}

public Subject find(String subjectid) {
    Subject found = null;
    Subject pointer = first;
    while (pointer != null) { 
        if (pointer.getSubjectID().equals(subjectid)) { 
            found = pointer; 
        }
        pointer = pointer.next;
    }
    return found;
}

Perhaps there's an error in addToList and find... Those are not shown though.. Anyway, it seems to be a rather boring assignment. — Alexander
– Alexander, Commented May 5, 2013 at 16:56
Somehow it seems that you actually do not have any List<Subject> anywhere... I would expect to see such a construct. But maybe you should reduce the problem to a shorter version and post then the full code of this condensed problem. — luksch
– luksch, Commented May 5, 2013 at 16:59
@luksch Of course (s)he doesn't---(s)he is "writing the datastructure h(im|er)self". It's a linked list, and this is shown in the posted code. — Marko Topolnik
– Marko Topolnik, Commented May 5, 2013 at 17:02
@camilla You should definitely post the code which shows how you came to the conclusion that the list contains both subjects. — Marko Topolnik
– Marko Topolnik, Commented May 5, 2013 at 17:06
If this kind of list implementation is not part of your requirement, I think you can use ArrayList<Subject>, which may simplify your problem. — iftee
– iftee, Commented May 5, 2013 at 17:10

rhinds · Accepted Answer · 2013-05-05 18:17:43Z

3

We really need the rest of the code to really confirm what is the problem, but from what you have posted, I will take an educated guess:

As you are implementing your own Linked List, that implementation has leaked through to the Subject class:

public class Subject() {
    Subject next; 
    //constructor with parameters
}

Here - any instance of Subject you create, if it is part of a list it will hold a reference to the next item in the Linked list.

For example, in the code you posted:

Subject subject1 = new Subject(parameters);
Subject subject2 = new Subject(parameters);

subjectlist.addToList(subject1);
subjectlist.addToList(subject2);

I assume that for your linked list implementation to be working, the SubjectList first variable points to subject1, and then subject1s next variable points to subject2.

This causes obvious problems when you try to us subject1 in any other list, as it still holds an reference to subject2.

If you really have/need to create your own implementation of a LinkedList for the particular project, then you could create a wrapper class, that has the next variables and a reference to Subject - that way, the LinkedList implementation doesn't leak through to the underlying objects at all.

e.g. something like:

public class SubjectWrapper {
    Subject subject;
    SubjectWrapper next; 
    //constructor with parameters
}

You don't need expose this underlying abstraction, and still pass subject1 to the addToList method, but in the method stick it inside the wrapper class.

edited May 5, 2013 at 18:17

answered May 5, 2013 at 17:28

rhinds

10.1k14 gold badges72 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Camilla Over a year ago

I have now added the addToList and find methods, but it appears that what you describe is the problem! I will try to create a wrapper class. Thank you so much for your time!

Julián Chamalé Over a year ago

Yeap, that's your problem. You can fixed it by adding a clone() method that return a new instance of your subject. You should just copy your values, except the .next reference obviously.

Collectives™ on Stack Overflow

Using two different objects of the same type in different classes in Java

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related