Is this break statement valid in jquery/javascript?

Question

I have a function which selects a text based on the input string. If both matches i make it selected. PFb the function,

function setDropdownTextContains(dropdownId,selectedValue,hfId){
            $('#'+dropdownId+' option').each(function(){

                     if($(this).text() === selectedValue){
                         $(this).attr("selected", "selected");
                         break;
                     }
            });
                 $('#'+hfId).val("ModelName doesnt match");
        }

I get the below error unlabeled break must be inside loop or switch ... What am i doing wrong??

The error message is self-explanatory. Your break is not in a loop or switch. Return false to stop the .each loop. — user1233508
– user1233508, Commented May 6, 2013 at 10:43

VisioN · Accepted Answer · 2013-05-06 10:43:03Z

23

The exception text is quite descriptive. You really can't use break statement inside if clause. In your case you should use return false to stop the .each() iteration.

answered May 6, 2013 at 10:43

VisioN

146k35 gold badges287 silver badges291 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

flavian · Accepted Answer · 2013-05-06 10:43:39Z

4

A break statement is designed to end a for, while or do-while loop or a switch statement. It has no side effects where you are using it. What are you trying to achieve?

In your specific case, just return false

answered May 6, 2013 at 10:43

flavian

28.6k11 gold badges68 silver badges107 bronze badges

Comments

Ivan Drinchev · Accepted Answer · 2013-05-06 10:43:23Z

2

$().each is a function method, so you will terminate it with return

function setDropdownTextContains(dropdownId,selectedValue,hfId){
    $('#'+dropdownId+' option').each(function(){   
         if($(this).text() === selectedValue){
             $(this).attr("selected", "selected");
             return false; // <--
         }
    });
    $('#'+hfId).val("ModelName doesnt match");
}

answered May 6, 2013 at 10:43

Ivan Drinchev

19.6k4 gold badges69 silver badges97 bronze badges

1 Comment

VisioN Over a year ago

Nope, return won't stop the iteration. It should return false.

Sudhir Bastakoti · Accepted Answer · 2013-05-06 10:44:22Z

2

to break you could just return false;, like

if($(this).text() === selectedValue){
    $(this).attr("selected", "selected");
    return false;
}

Returning 'false' from within the each function completely stops the loop through all of the elements (this is like using a 'break' with a normal loop). Returning 'true' from within the loop skips to the next iteration (this is like using a 'continue' with a normal loop)

answered May 6, 2013 at 10:44

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

Comments

Harish · Accepted Answer · 2013-05-06 10:48:08Z

1

As per jQuery documentation, break is to break out of the loop. You cannot use it inside if statement.

You can use return false instead.

jQuery.each(arr, function() {
      $("#" + this).text("Mine is " + this + ".");
       return (this != "three"); // will stop running after "three"
   });

answered May 6, 2013 at 10:48

Harish

1,51916 silver badges43 bronze badges

Collectives™ on Stack Overflow

Is this break statement valid in jquery/javascript?

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related