Compare date in javascript

Question

I have a custom validator that points to a Client side script to validate a textbox.

My date and time are separated into two textboxes - one with date in mm/dd/yyyy format and the other with time in hh:mm am/pm format.

I need to make sure the textboxes together are not greater than now. How can i accomplish this?

Here is what i have so far. what am i doing wrong?

function checkminutes(sender, args) {
        var txtdate = $get('<%=FormView1.FindControl("txtdate").ClientID %>');
        var txttime = $get('<%=FormView1.FindControl("txttime").ClientID %>');
        var totaltime = txtdate.value + ' ' + txttime.value;
        totaltime = Date(totaltime);
        var d = new Date();
        if (totaltime > d) {
            args.IsValid = false;
        }
        else {
            args.IsValid = true;
        }


    }

This is the answer that worked.

function checkminutes(sender, args) {
        var txtdate = $get('<%=FormView1.FindControl("txtdate").ClientID %>');
        var txttime = $get('<%=FormView1.FindControl("txttime").ClientID %>');
        var totaltime = txtdate.value + ' ' + txttime.value;
        totaltime = Date.parse(totaltime);
        var d = new Date();
        if (totaltime > d) {
            args.IsValid = false;
        }
        else {
            args.IsValid = true;
        }
    }

I feel like I've said this a million times. Make sure that you validate server-side, as any client-side validation can be circumvented. I used to get around twitter's 140 character limit that way. — geowa4
– geowa4, Commented Oct 29, 2009 at 15:27

TStamper · Accepted Answer · 2009-10-29 16:02:10Z

1

Just compare the milliseconds since the epoch:

totaltime = new Date("1988/02/21 08:08");
d = new Date();
if (totaltime.getTime() < d.getTime())
    alert("Date is valid");
else
    alert("Try again, Date is not valid");

EDIT: I can't seem to get it to work when I use "am/pm", so just convert it to 24 time, and it will be fine.

edited Oct 29, 2009 at 16:02

TStamper

30.4k10 gold badges69 silver badges73 bronze badges

answered Oct 29, 2009 at 15:39

geowa4

42.1k17 gold badges90 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Josh Stodola · Accepted Answer · 2009-10-29 15:26:51Z

0

Don't waste your time validating this on the client-side. It's never going to be reliable, and no matter what you are going to have to validate on the server-side anyway.

answered Oct 29, 2009 at 15:26

Josh Stodola

82.8k48 gold badges187 silver badges229 bronze badges

4 Comments

Eric Over a year ago

But you cannot get the exact time on server side validation. Unless the page is refreshed or i use updatepanels.

geowa4 Over a year ago

no, validate client-side so the user gets immediate feedback that something is wrong. then validate server-side to make sure that it wasn't circumvented in a possibly malicious attempt.

Eric Over a year ago

i like your answer geowa4. But what is my issue in the above code?

TStamper Over a year ago

@geiwa4- i agree, thats what validating on client side is for, immediate feedback, but you were saying its a waste of time which is why I disagreed

Dean J · Accepted Answer · 2009-10-29 15:56:23Z

0

You shouldn't be using javascript popups to alert the user there was a problems; they're clunky at best.

Unless you're telling the user there was a problem with AJAXy pages, just do server side validation, and your application will be slicker looking. I'm assuming if you're asking this particular question, you're not doing AJAX.

As far as serverside validation not having "the exact time", you're dealing with hours and minutes, not milliseconds.

answered Oct 29, 2009 at 15:56

Dean J

40.5k17 gold badges71 silver badges95 bronze badges

Collectives™ on Stack Overflow

Compare date in javascript

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related