C# StackOverflowException when use getter

Question

I have getter which changes the first letter of a string to capital. But I get StackOverflowException.

namespace ConsoleApplication1
{
    class Program
    {
        class Human
        {     
            public String Name
            {
                get
                {

                    char[] letters = Name.ToCharArray();
                    // upper case the first char
                    letters[0] = char.ToUpper(letters[0]);
                    // return the array made of the new char array
                    return new String(letters);
                    //return Name.First().ToString().ToUpper() + String.Join("", Name.Skip(1));
                }
                set
                {
                
                }
            }

What did I do wrong?

Give the boy a chance, he might be a beginner struggling with his first lines of code. — Geeky Guy
– Geeky Guy, Commented May 8, 2013 at 21:18
First, your example code won't compile. 2 return statements and an open parenthesis. Second, your getter is referencing itself recursively. You need to set up a private string _Name and do your calculations on it. — MadHenchbot
– MadHenchbot, Commented May 8, 2013 at 21:21
Yes is my first line of code in C#. Anyway CLAPTRAP revolution!:P — Aku
– Aku, Commented May 9, 2013 at 16:24

I4V · Accepted Answer · 2013-05-08 21:16:42Z

6

This line char[] letters = Name.ToCharArray(); calls recursively the property public String Name

answered May 8, 2013 at 21:16

I4V

35.4k6 gold badges71 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Martin Mulder · Accepted Answer · 2013-05-08 21:45:51Z

4

Your property Name is calling itself in line char[] letters = Name.ToCharArray();. You will have to use a field instead of the property:

class Human
{     
    private string _name;

    public String Name
    {
        get
        {
            if (_name == null)
                return null;
            if (_name.Length <= 1)
                return _name.ToUpper() + _name.Substring(1);
            return _name.Substring(0, 1).ToUpper() + _name.Substring(1);
        }
        set
        {
            _name = value;
        }
    }
}

I also took the freedom to try to make your function work with the upper casing. Or in my opinion even better:

class Human
{     
    private string _name = "";

    public String Name
    {
        get
        {
            return _name;
        }
        set
        {
            if (String.IsNullOrEmpty(_name))
                _name = value;
            else  
                _name = value.Substring(0, 1).ToUpper() + _value.Substring(1);
        }
    }
}

edited May 8, 2013 at 21:45

answered May 8, 2013 at 21:17

Martin Mulder

13k3 gold badges30 silver badges57 bronze badges

2 Comments

MadHenchbot Over a year ago

Move your _name field out of the property and I'll upvote it. :)

Martin Mulder Over a year ago

@MadHenchbot: Hahaha, that is a nice and stupid mistake! Thanks! :)

Kenneth · Accepted Answer · 2013-05-08 21:16:53Z

That's because you are accesing the getter inside the getter.

You should create a backing variable and access that variable instead of the Name:

class Human
    {     
    private string _name = string.Empty;    
    public String Name
        {
            get
            {

                char[] letters = _name.ToCharArray();  // use the backing variable instead of Name
                // upper case the first char
                letters[0] = char.ToUpper(letters[0]);
                // return the array made of the new char array
                return new String(letters);
                //return Name.First().ToString().ToUpper() + String.Join("", Name.Skip(1));

                return new String(;// ToUpperFirstLetter(this.Imie);
            }
            set
            {
                _name = value;
            }
        }

Geeky Guy · Accepted Answer · 2013-05-08 21:17:35Z

1

This:

char[] letters = Name.ToCharArray();

When you try to read something from Name, you're using the getter. Thus you've caused an infinite loop.

answered May 8, 2013 at 21:17

Geeky Guy

9,3895 gold badges46 silver badges65 bronze badges

Comments

Martin · Accepted Answer · 2013-05-08 21:35:53Z

0

Here's a working Name method, which makes the first letter of the sentence uppercase, when you get the value.

private string _name;
public string Name
{
    get
    {
        if (string.IsNullOrEmpty(_name))
        {
            return _name;
        }
        var charArray = _name.ToCharArray();
        charArray[0] = char.ToUpper(charArray[0]);
        return new string(charArray);
    }
    set { _name = value; }
}

answered May 8, 2013 at 21:35

Martin

2,3202 gold badges30 silver badges42 bronze badges

Collectives™ on Stack Overflow

C# StackOverflowException when use getter

5 Answers 5

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related