PHP regex numbers in url

Question

I've got a blog, I want to display ADS or special text on the MAIN page but not on any other page with the URI /?paged=[number]. I've tried the standard regex /^[0-9].$/ but it fails to match.

I'm not sure what I've done wrong or how to go about doing this

if (substr_count($_SERVER[REQUEST_URI], "/") > 0 AND
substr_count($_SERVER[REQUEST_URI], "/?paged=1") == 0 AND
substr_count($_SERVER[REQUEST_URI], "/?paged=2") == 0 AND
substr_count($_SERVER[REQUEST_URI], "/?paged=3") == 0 AND
substr_count($_SERVER[REQUEST_URI], "/?paged=4") == 0 AND
substr_count($_SERVER[REQUEST_URI], "/?paged=5") == 0) {
echo "display special text, banners, and other stuff";
}

This is how I'm doing it currently, but I don't want to do thousands of these...

When I see code like this I'm reminded of why I don't miss thedailywtf.com anymore since I became more active on SO. — Niels Keurentjes
– Niels Keurentjes, Commented May 13, 2013 at 12:30
If you take a look at your logical comparison IT HAS NO SENSE. You are checking if your URI have "/?paged=1", "/?paged=2", "/?paged=3", "/?paged=4", "/?paged=5" at the same time and this will NEVER match, obviusly. You have to add OR instead of AND — DaGLiMiOuX
– DaGLiMiOuX, Commented May 13, 2013 at 12:30
btw, /^[0-9].$/ means, a digit, then any character. The dot is a wildcard itself. Perhaps you meant to use + ? — barryhunter
– barryhunter, Commented May 13, 2013 at 12:32

barryhunter · Accepted Answer · 2013-05-13 14:30:57Z

7

Can you not just check for the presence of paged in the GET array?

if(!isset($_GET['paged'])) {
    // You know this is the main page.
}

edited May 13, 2013 at 14:30

barryhunter

21.1k3 gold badges32 silver badges44 bronze badges

answered May 13, 2013 at 12:27

christopher

27.4k6 gold badges58 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Wolfman Joe Over a year ago

Plus one. And even if you want to make sure it's a valid number - then make sure those valid numbers are stored somewhere so you can check it against a database. There's no way those should be hardcoded in.

christopher Over a year ago

@WolfmanJoe Agreed. It's often best to port values like that into some persistent structure, so your code is as flexible as possible.

Stephan · Accepted Answer · 2013-05-13 12:33:21Z

0

Try this:

if (preg_match('#paged=\d+#', $_SERVER[REQUEST_URI]) {
    echo "display special text, banners, and other stuff";
}

answered May 13, 2013 at 12:33

Stephan

43.2k69 gold badges245 silver badges342 bronze badges

Comments

bato3 · Accepted Answer · 2013-05-13 12:38:08Z

0

Regex: /^[0-9].$/ would be correct for "3k" string. Analize this patterns

/page=(\d+)/
/page=([1-5])/
/^\/\?page=([1-5])$/
/page=(?<page>[1-5])/

answered May 13, 2013 at 12:38

bato3

2,8251 gold badge21 silver badges26 bronze badges

Comments

Cristian · Accepted Answer · 2013-05-13 12:39:06Z

0

Why not using the regexp in the GET parameter ?

<?php
$regexp = "/^(\d+)+$";
if (preg_match($regexp, $_GET['paged'])) {
    #...your code
} else {
    #...your code
}

Or (if you want to use the entire string) try this:

<?php
$regexp = "/^(\/\?paged)+=(\d+)+$/";

answered May 13, 2013 at 12:39

Cristian

3272 silver badges9 bronze badges

Collectives™ on Stack Overflow

PHP regex numbers in url

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related