Javascript is not being called from ASP.NET User Control

Question

I converted an ASP.NET page DeleteUser.aspx into a user control DeleteUser.ascx.

The aspx page had a simple javascript function like this:

function deleteConfirmation() {

    var xusername = document.getElementById('<%= txtusercn.ClientID %>').value;
    if (xusername != null && xusername != "") {
        var userTextBoxId = '<%= txtusercn.ClientID %>';
        var uname = document.getElementById(userTextBoxId).value;
        return confirm('Are you sure you want to delete \'' + uname + '\'?');
    }
    else {
        alert('Please enter Usercn');
        return false
    }
}

Now since this is converted into a user control, DeleteUser.ascx, I first moved this javascript code into the containing aspx file in the <head> tag. The page was throwing an exception txtusercn is not in the scope of the containing aspx file.

Then I moved the javascript function into a separate javascript file DeleteUser.js and referenced it from DeleteUser.ascx.cs like this:

protected void Page_Load(object sender, EventArgs e)
{
    Page.ClientScript.RegisterClientScriptInclude(typeof(DeleteUser),"DeleteUserScript",@"../scripts/DeleteUser.js");
}

The javascript function is not being called here, but when I check the containing aspx file's page source, I can see that the javascript function is registered properly.

Why is the javascript function not being called even after the page refers to the javascript file DeleteUser.js

Edit:

Invoking the function like this:

<asp:Button ID="btndeleteusercn" runat="server" Text="Delete Usercn" OnClick="btndeleteusercn_Click" OnClientClick="return deleteConfirmation();" />

How are you invoking the function? What does your browser debug console/firebug/dev tools/etc. say, if any error? — EdSF
– EdSF, Commented May 14, 2013 at 10:17
did you check produced markup (script tag) ? I would bet that there is a problem with right folder. If your scripts folder is in site root try with the "/scripts/DeleteUser.js", btw. you don't need @ for slash (/) — Antonio Bakula
– Antonio Bakula, Commented May 14, 2013 at 10:22
@EdSF: I edited the question with how I invoke the function. — Animesh D
– Animesh D, Commented May 14, 2013 at 10:29
@AntonioBakula: The script is being referenced corrected as evident from the view-source page. — Animesh D
– Animesh D, Commented May 14, 2013 at 10:29

user2160658 · Accepted Answer · 2013-05-14 10:26:00Z

1

I guess, "<%= txtusercn.ClientID %>" must be creating the JavaScript Error as such Server Control reference should be on the page on which the related control exists. You should pass the ControlID through parameters to the function and then it should work.

function deleteConfirmation(ctrlID) {

var xusername = document.getElementById(ctrlID).value;
if (xusername != null && xusername != "") {
    var userTextBoxId = ctrlID;
    var uname = document.getElementById(userTextBoxId).value;
    return confirm('Are you sure you want to delete \'' + uname + '\'?');
}
else {
    alert('Please enter Usercn');
    return false
}}

and call the Method from by passing the ID from there. such as

deleteConfirmation('ID of Control')

answered May 14, 2013 at 10:26

user2160658

292 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nitin Aggarwal · Accepted Answer · 2013-05-14 10:47:29Z

1

Please try this updated code.

function deleteConfirmation() {

        var xusername = document.getElementById('<%= txtusercn.ClientID %>').value;
        if (xusername != null && xusername != "") {
            return confirm('Are you sure you want to delete \'' + xusername + '\'?');
        }
        else {
            alert('Please enter Usercn');
            return false
        }
return true;

    }

answered May 14, 2013 at 10:47

Nitin Aggarwal

4711 gold badge8 silver badges18 bronze badges

Comments

Animesh D · Accepted Answer · 2013-05-14 11:06:53Z

0

The client ID of the text box is being rendered as DeleteUser1_txtusercn, so I changed the javascript like this and it worked:

function deleteConfirmation() {

    var uname = document.getElementById('DeleteUser1_txtusercn').value;
    if (uname != null && uname != "") {
        return confirm('Are you sure you want to delete \'' + uname + '\'?');
    }
    else {
        alert('Please enter UserCN');
        return false;
    }
}

answered May 14, 2013 at 11:06

Animesh D

5,03014 gold badges75 silver badges110 bronze badges

Collectives™ on Stack Overflow

Javascript is not being called from ASP.NET User Control

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related