Convert to binary with loop displays only the numbers, not binary

Question

the idea is that the program will show numbers and their binary equivalent but it is showing only the numbers and one binary on the end,what is wrong

public class Convert {

    public static void main(String[] args) {
        int number;
        for (number = 0; number < 4095; number++) {
            System.out.println("Number is :" + number);
        }
        System.out.print("Convert to binary is:");
        System.out.print(binaryform(number));
    }

    private static Object binaryform(int number) {
        int remainder;
        if (number <= 1) {
            System.out.print(number);
            return null;
        }
        remainder = number % 2;
        binaryform(number >> 1);
        System.out.print(remainder); {
        }
        return remainder;
    }
}

Why are you using your own binary calculation when there is a built in lib? — Tdorno
– Tdorno, Commented May 15, 2013 at 17:15
@Dan4o He means the method suggested by user000001: Using the pre-defined method Integer.toBinaryString(number) instead of defining your own method binaryForm(number). — Lone nebula
– Lone nebula, Commented May 15, 2013 at 17:37

user000001 · Accepted Answer · 2013-05-15 17:17:10Z

2

You can use

Integer.toBinaryString(number));

answered May 15, 2013 at 17:17

user000001

33.7k14 gold badges86 silver badges113 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sanjaya Liyanage · Accepted Answer · 2013-05-15 17:15:27Z

1

change it as below

for(number=0;number<4095;number++){

System.out.println("Number is :"+ number);
System.out.print("Convert to binary is:");
System.out.print(binaryform(number));
}

answered May 15, 2013 at 17:15

Sanjaya Liyanage

4,75610 gold badges38 silver badges51 bronze badges

5 Comments

Sanjaya Liyanage Over a year ago

because in the for loop you should do whatever you want for each number.at the end of the loop the number will be 4095 and it will exit the loop.so the binary was printed for you is for 4095

Dan4o Over a year ago

The code works but starts around 2500,not from 0,what is wrong now?And the binary is 13 numbers ,but they supposed to be 12...........

Lone nebula Over a year ago

@Dan4o It does start at 0. However, it most likely shows the x most recent lines only, to save memory. Also, your binaryForm method is wrong.

Sanjaya Liyanage Over a year ago

@Dan4o it is because of memory leak or a lack of execution memory.You can write it to a file and checked or just increase the memory and test.If you change the number in the loop from 4095 to 200 then you will see that it is printing from 0

Sanjaya Liyanage Over a year ago

@Dan4o Integer.toBinaryString(number)) is ok

sha1 · Accepted Answer · 2013-05-15 17:17:13Z

0

In here:

System.out.print("Convert to binary is:");

you are not in the for loop, so that it will only print out the numbers and just the last number's binary equivalent.

answered May 15, 2013 at 17:17

sha1

1438 bronze badges

Collectives™ on Stack Overflow

Convert to binary with loop displays only the numbers, not binary

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related