jsp method is not functioning properly inside javascript method

Question

In my jsp page I have a jsp button like this.

     <input class="submit_button" type="submit" name="Payment" value="Payment"          
     style="position: absolute; left: 350px; top: 130px;" 
     onclick="javascript:payment();">

And I have onclick javascript function which call the jsp method "callProcedure()" like this.

<script>
     function payment(){
     alert('Payment done successfully...');
    <%                  
      callProcedure();  // calls the procedure                       
    %>
</script>

And the jsp method callProcedure() calls the oracle procedure like this

<%! void callProcedure() {
    CallableStatement cst = null;
    Connection conn = null;      

    try {

        DBDataSource dbDataSource = new DBDataSource();
        conn = dbDataSource.makeConnection();
        conn.setAutoCommit(false);           
        String insertStoreProc = "{call 
        p_webservice_test(?,?,?,?,?,?,?,?,?,?,?,?,?,?)}";
        cst = conn.prepareCall(insertStoreProc);

        cst.setString(1, TransID);
        cst.setString(2, RemitNo);
        cst.setString(3, senderFName + senderMName + senderLName);
        cst.setString(4, RFName + RMName + RLName);
        cst.setString(5, RAddr);
        cst.setString(6, RPh);
        cst.setString(7, Relshp);
        cst.setString(8, tDate.toString());
        cst.setString(9, PayCur);
        cst.setBigDecimal(10, paymentAmt);
        cst.setString(11, Pcode);
        cst.registerOutParameter(12, Types.VARCHAR);
        cst.executeUpdate();  
        conn.commit();

    } catch (SQLException e) {
        System.out.println("Error:::" + e.getMessage());
    } finally {
        if (cst != null) {
            try {
                cst.close();
            } catch (Exception ex) {
                System.out.println("Error:" + ex.getMessage());
            }
        }
    }
}
%>

Here, my problem is that the jsp method "callProcedure()" execute before clicking the button or before executing the javascript method. Whats the exact problem and the solution for this problem. Please reply as soon as possible.

Thanks In Advance...

All JSP is run on the server so you cant call a jsp method on a javascript event. — me_digvijay
– me_digvijay, Commented May 17, 2013 at 6:38
what should I do to call the jsp method on jsp button click? — Suniel
– Suniel, Commented May 17, 2013 at 6:42

me_digvijay · Accepted Answer · 2013-05-17 10:48:25Z

2

All JSP is run on the server before even loading the page. What you see is the output of the jsp page. So you cant call a jsp method on a javascript event. Here in your case the jsp method is executing on the server and the result is shown to you.

You can put the code of the callProcedure() method in some servlet and then using the input button you can submit the form to the servlet, which will call the callProcedure() method and show the result n the page

One more thing I haven't seen or heard about the JSP button as you have specified in the post.

edited May 17, 2013 at 10:48

answered May 17, 2013 at 6:40

me_digvijay

5,53210 gold badges52 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Suniel Over a year ago

Thanks a lot. But can the value of jsp page used in procedure (like TransID, RemitNo) be passed to the servlet?

me_digvijay Over a year ago

@Suniel: If these attributes are unique for each user you can store them as session attributes and then the servlet can get these attributes from the session.

Suniel Over a year ago

I tried but it gives null values. Can i call the java method of jsp page in servlet?

me_digvijay Over a year ago

As NK123: has suggested its bad to right java code in your jsp, so try to move your code to either a servlet or a bean (simple java class). Before calling any method, you need to have it defined or accessible to where you are calling it. So, I would say move the JSP code to the servlet. Also for the null value that you are getting, make sure you add the objects to the session and you are using the same session to access those variables.

KhAn SaAb · Accepted Answer · 2013-05-17 06:44:23Z

1

Avoid direct calling methods in javascript redirect to servlets and call your callProcedure() method.

 location.href=/packagename/ServletName'

my suggestion writting java code in jsp not a good practice.

answered May 17, 2013 at 6:44

KhAn SaAb

5,4166 gold badges34 silver badges55 bronze badges

Comments

JDGuide · Accepted Answer · 2013-05-17 06:52:24Z

1

My suggestion is call the servlet by clicking on button. Inside that servlet call your procedure and return the result(if any result exist) by session to the same page.

Change the submit button to only button .

<input class="submit_button" type="button" name="Payment" 
     value="Payment"          
     style="position: absolute; left: 350px; top: 130px;" 
     onclick="javascript:payment();">

The javascript function like below :-

<script language="javascript">

 function payment(){
   document.formname.action="<%=request.getContextPath()%>/servletpath/myservlet";
   document.formname.submit();
}
</script>

Hope it will help you.

answered May 17, 2013 at 6:52

JDGuide

6,50112 gold badges52 silver badges67 bronze badges

2 Comments

Suniel Over a year ago

Can I call the method of jsp page in the servlet?

JDGuide Over a year ago

Better , you define that jsp method inside servlet and return the result to you JSP.

Collectives™ on Stack Overflow

jsp method is not functioning properly inside javascript method

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related