PHP script only returns first row of SELECT statement

Question

I have a php script to run mssql queries. When I run a query like, "SELECT first_name, last_name, mi FROM users", all I get back is 'first_name'. Here's the script:

<?php

require '../../scripts/database_connection.php';

$query_text = $_REQUEST['query'];
$result = mssql_query($query_text);

 if (!result) {
   die("<p>Error: " . $query_text ."</p>");
}

$return_rows = true;
 if (preg_match("/^\s*(CREATE|INSERT|UPDATE|DELETE|DROP)/i,
   trim(strtoupper($query_text)))) {
  $return_rows = false;
}

if ($return_rows) {
 echo "<p>Results from your query:</p>";
 echo "<ul>";

while ($row = mssql_fetch_row($result)) {
 echo "<li>{$row[0]}</li>";
}

 echo "</ul>";
}

 else {

  if ($result) {
   echo "<p>Your query was processed successfully.</p>";
   echo "<p>$query_text</p>";
 }
}

?>

Any suggestions?

taking the mssql query via query string and execute it, dont this seem like a big security hole? — Mithun Satheesh
– Mithun Satheesh, Commented May 23, 2013 at 12:08
it absolutly IS a huge security risk. I assume it is only a local test script. If not, never accept outside parameters ($_REQUEST) as input for executable code (like a query) and never use unfiltered variables. — ToBe
– ToBe, Commented May 23, 2013 at 13:17

ToBe · Accepted Answer · 2013-05-23 13:14:54Z

1

A $row is an array with all columns of your select. Just iterate with foreach or implode it:

while ($row = mssql_fetch_row($result)) {
    echo "<li>".implode(" - ", $row)."</li>";
}

You might also want to use mssql_fetch_assoc to get the respective column names:

answered May 23, 2013 at 13:14

ToBe

2,6791 gold badge20 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

noamik · Accepted Answer · 2013-05-23 12:07:51Z

0

Did you try to access $row[1] and $row[2]?

    while ($row = mssql_fetch_row($result)) {
     echo "<li>{$row[0]} - {$row[1]} - {$row[2]}</li>";
    }

answered May 23, 2013 at 12:07

noamik

8277 silver badges22 bronze badges

Collectives™ on Stack Overflow

PHP script only returns first row of SELECT statement

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related