php save to csv file

Question

I'm wanting to store basic data from a single form box and I've created this php code base, but it doesn't seem to be working. Can someone take a glance and see if anything stands out to why this wouldn't work. Edit: the csv file never updates with new data

if (isset($_POST["submit"])) 
{ 
    $name = $_POST["name"]; 
    date_default_timezone_set('America/New_York');
    $date = date('Y-m-d H:i:s');

    if (empty($name)) 
    { 
        echo "ERROR MESSAGE"; 
        die; 
    } 
    $cvsData ='"$name","$date"'.PHP_EOL; 
    $cvsData .= "\"$name\",\"$date\"".PHP_EOL; 
    $fp = fopen("emailAddressses.csv", "a");

    if ($fp) 
    { 
        fwrite($fp,$cvsData); // Write information to the file 
        fclose($fp); // Close the file 
    }
}

What does 'it doesn't seem to be working' mean? Does it do nothing? Something, but not what you expect? — andrewsi
– andrewsi, Commented May 24, 2013 at 18:46
Would be nice to know what "doesn't seem to be working" means. Error, empty file...? — Marcel Gwerder
– Marcel Gwerder, Commented May 24, 2013 at 18:46
Is there any error ? Could you put 'error_reporting (E_ALL);' and recheck ? — Dom
– Dom, Commented May 24, 2013 at 18:46
Code seems fine if both submit & name are set, I'd recommend fputscv, but for anything more than "it doesn't seem to be working" we need a more exact error. — Wrikken
– Wrikken, Commented May 24, 2013 at 18:47
PHP has built-in CSV handling functions. Any reason why you aren't using them? — Spudley
– Spudley, Commented May 24, 2013 at 19:05

Sumoanand · Accepted Answer · 2013-05-24 19:06:35Z

7

Use the nicer way in php : fputcsv

Otherwise you need to do lot of error handling to achieve in your case.

$list = array (
    array('First Name', 'Last Name', 'Age'),
    array('Angelina ', 'Jolie', '37'),
    array('Tom', 'Cruise', '50')
);

$fp = fopen('file.csv', 'w');

foreach ($list as $fields) {
    fputcsv($fp, $fields);
}

fclose($fp);

answered May 24, 2013 at 19:06

Sumoanand

8,9293 gold badges50 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

atlMapper Over a year ago

I haven't started error trapping because I'm testing and not getting the file to submit was my first problem before hardening, but thanks I'm going down this route now.

MaX · Accepted Answer · 2013-05-24 18:53:40Z

3

You should look into fputcsv. This will add CSV to you file and take care of fields and line ends.

fputcsv($fp,array(array($name,$date)));

You can also specify delimiters and such if you want.

answered May 24, 2013 at 18:53

MaX

1,81514 silver badges17 bronze badges

1 Comment

atlMapper Over a year ago

thanks I wasn't aware of fputcsv which is a much cleaner way to accomplish this task

Ibu · Accepted Answer · 2013-05-24 18:47:12Z

0

This part will not behave like you expect, the variables are not evaluated when inside single quotes:

$cvsData ='"$name","$date"'.PHP_EOL;

You will need to use double quotes:

$cvsData ="\"$name\",\"$date\"".PHP_EOL;

answered May 24, 2013 at 18:47

Ibu

44k14 gold badges82 silver badges109 bronze badges

2 Comments

Spudley Over a year ago

it wasn't me, but since he's got two lines going into the CSV, with different quote styles, my guess is that he's aware of that and intending the first line (with the single quotes) to be a header line that has the variable name as headers. I agree it's not clear what the intention is, but it is clear from the two lines that he is aware of how quotes work.

atlMapper Over a year ago

@Spudley correct I'm going for headers in the csv, thanks though...I'm a JS guy still understanding the php syntax and usage

Collectives™ on Stack Overflow

php save to csv file

3 Answers 3

1 Comment

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related