C dynamic memory / C string

Question

This is something similar to what I am trying to do (I skipped code which checks if memory was allocated):

    sscanf(line, "%[^\"]\"%[^\"]", tempString, tempString);
    int length = strlen("stackoverflow.com") + strlen(tempString);
    tempQuestion.link = (char *)malloc((length + 1) * sizeof(char));
    tempQuestion.link = "stackoverflow.com";
    strcat(tempQuestion.link, tempString);

Program crashes after it reaches strcat. I can't figure out what could possibly be wrong.

deinst · Accepted Answer · 2013-05-25 15:32:23Z

3

When you assign tempQuestion.link = "stackoverflow.com" you change the pointer tempQuestion.link. You want to use strncpy to copy the string.

Change the last two lines to

strncpy(tempQuestion.link, "stackoverflow.com", length);
strcat(tempQuestion.link, tempString);

edited May 25, 2013 at 15:32

answered May 25, 2013 at 14:40

deinst

18.9k3 gold badges49 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Deepu · Accepted Answer · 2013-05-25 14:44:32Z

1

The following line causes the error,

tempQuestion.link = "stackoverflow.com";

Instead copy as follows,

strcpy(tempQuestion.link, "stackoverflow.com");

answered May 25, 2013 at 14:44

Deepu

7,6104 gold badges28 silver badges50 bronze badges

Collectives™ on Stack Overflow

C dynamic memory / C string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related